Merged
Conversation
Collaborator
|
We still need to test jruby 1.9 until version sidekiq 4.x |
Contributor
Author
|
@seuros jruby-19 refers to the current jruby used in 1.9 mode. 1.9 is the default since jruby 1.7. Both jruby and jruby-19mode refer to jruby 1.7.19 so I don't think it's necessary. |
Collaborator
|
Thanks you for your contribution. |
Contributor
Author
|
Thanks for your work on coderwall and state_machine gem among other things ;) :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed jruby-19mode as this is kind of the default now and added testing with jruby-head (that may fail) to help JRuby get prepped for an awesome 9k release :)