Skip to content

Make pry-byebug available on ruby 2.2.2 too#2375

Merged
davydovanton merged 1 commit intosidekiq:masterfrom
mrsimo:byebug-mri-2-2
Jun 3, 2015
Merged

Make pry-byebug available on ruby 2.2.2 too#2375
davydovanton merged 1 commit intosidekiq:masterfrom
mrsimo:byebug-mri-2-2

Conversation

@mrsimo
Copy link
Contributor

@mrsimo mrsimo commented Jun 3, 2015

Hopefully a simple one. pry-byebug also works under mri 2.2.

Gemfile Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be we set mri instead :mri_21, :mri_22 for any MRI versions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only supports MRI 2.0.0 or newer. For MRI 1.9.3 or older, use pry-debugger

This is only a tool for development, so I think that would be fine. Specially since sidekiq doesn't support 1.9. I'll change it!

@davydovanton
Copy link
Contributor

@mrsimo please squash your commits 😊

Should be fine, since we don't support 1.9
@mrsimo
Copy link
Contributor Author

mrsimo commented Jun 3, 2015

Done!

davydovanton added a commit that referenced this pull request Jun 3, 2015
Make pry-byebug available on ruby 2.2.2 too
@davydovanton davydovanton merged commit acf61a6 into sidekiq:master Jun 3, 2015
@davydovanton
Copy link
Contributor

@mrsimo thank you for contributing 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants