Use created_at for the time schedule jobs are scheduled#2376
Merged
mperham merged 1 commit intosidekiq:masterfrom Jun 3, 2015
mrsimo:rename-enqueued-at-created-at
Merged
Use created_at for the time schedule jobs are scheduled#2376mperham merged 1 commit intosidekiq:masterfrom mrsimo:rename-enqueued-at-created-at
mperham merged 1 commit intosidekiq:masterfrom
mrsimo:rename-enqueued-at-created-at
Conversation
lib/sidekiq/client.rb
Outdated
Collaborator
There was a problem hiding this comment.
Should this property be set inside atomic_push instead when we know the job is actually being enqueued?
Contributor
Author
There was a problem hiding this comment.
That makes more sense! Pushed https://github.com/mrsimo/sidekiq/commit/b091d5c0542940780d9ddda765e0b8a1bd08ec02
Collaborator
|
Really nice work. Add a Changes entry as this can easily break people's code. |
Contributor
Author
|
Added the entry to Changes in https://github.com/mrsimo/sidekiq/commit/af5e59a9915281b4a4d5c9768795152e9bffcb59 Started a new section for 3.3.5, since 3.3.4 is already released. Would you like the commits squashed? |
Collaborator
|
Looks great, yes please squash. |
When a job is scheduled, it should have a created_at time, and get a enqueued_at when it's actually enqueued back into a queue.
Contributor
Author
|
Squashed! |
mperham
added a commit
that referenced
this pull request
Jun 3, 2015
Use created_at for the time schedule jobs are scheduled
jonhyman
added a commit
that referenced
this pull request
Jul 24, 2015
… since enqueued_at only gets set when jobs are put into queues, not when they are scheduled (from #2376).
jonhyman
added a commit
that referenced
this pull request
Jul 24, 2015
… since enqueued_at only gets set when jobs are put into queues, not when they are scheduled (from #2376).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the discussion in #2373, wanted to give this a try.
When a job is scheduled, it should have a
created_attime, and get anenqueued_atwhen it's actually enqueued back into a queue.