Testing clear_all and drain_all#455
Merged
mperham merged 1 commit intosidekiq:masterfrom Oct 19, 2012
Merged
Conversation
Collaborator
|
Hot!! |
mperham
added a commit
that referenced
this pull request
Oct 19, 2012
Testing clear_all and drain_all
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just floating an idea, not sure if you'll like it.
In a few apps now we've ended up adding clear_all and drain_all functionality to things like rspec and cucumber hooks. This just makes it easier.
Investigated using inclusion tracking a la ActiveSupport's DependencyTracker, but this doesn't catch the Sidekiq::Extensions workers and potentially other workers defined prior to inclusion of sidekiq/testing.
A couple of potential issues:
This may be too far down the path of reimplementing sidekiq in-memory for testing.