Skip to content

Enhanced the UI a bit. See http://d.pr/i/rcGz#475

Merged
mperham merged 2 commits intosidekiq:masterfrom
coderberry:master
Oct 29, 2012
Merged

Enhanced the UI a bit. See http://d.pr/i/rcGz#475
mperham merged 2 commits intosidekiq:masterfrom
coderberry:master

Conversation

@coderberry
Copy link

I enhanced the UI a bit. Here's a screenshot:

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

? Isn't this always true?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops.. sorry.. that was debugging 👎 -1:

@mperham
Copy link
Collaborator

mperham commented Oct 29, 2012

Wow, that looks amazing.

mperham added a commit that referenced this pull request Oct 29, 2012
@mperham mperham merged commit e3a08be into sidekiq:master Oct 29, 2012
@unity
Copy link
Contributor

unity commented Oct 30, 2012

Live poll Button is more visible but that was not something needed IMHO.
Also, vertical alignment is broken for the stats panel, and the treatment sets it apart in a bad way...
Just my opinion though.

UI is very light right now but when adding features in the future, I think that this will bite back.
I went for minimal treatment in prevision of more UI elements.

@mperham
Copy link
Collaborator

mperham commented Oct 30, 2012

@unity The UI is never set in stone. you are welcome to clean up as you see fit.

I had to move the redis/time info to a navbar footer since hostnames can get long and ours didn't fit into that tiny sidebar box. Polish would be very welcome there.

@coderberry
Copy link
Author

Here's another version I created: http://d.pr/i/9kOn

Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants