Use regular object for exception data#504
Merged
mperham merged 1 commit intosidekiq:masterfrom Nov 5, 2012
dbussink:master
Merged
Use regular object for exception data#504mperham merged 1 commit intosidekiq:masterfrom dbussink:master
mperham merged 1 commit intosidekiq:masterfrom
dbussink:master
Conversation
This test doesn't assert anything about the test data itself. Therefore using a regular object is fine. This also fixes the build for Rubinius. The problem is that a minitest mock object removes all kinds of methods that should be there. Since exception_data is for example used in an array later on, it should respond to methods like equal? and == in order to be able to behave properly in an array. In MRI you can get away with this, because once you go into C land, you don't go back to Ruby until you're done. This means you can remove methods that data structures normally depend on without MRI breaking.
mperham
added a commit
that referenced
this pull request
Nov 5, 2012
Use regular object for exception data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test doesn't assert anything about the test data itself. Therefore
using a regular object is fine.
This also fixes the build for Rubinius. The problem is that a minitest
mock object removes all kinds of methods that should be there. Since
exception_data is for example used in an array later on, it should
respond to methods like equal? and == in order to be able to behave
properly in an array.
In MRI you can get away with this, because once you go into C land, you
don't go back to Ruby until you're done. This means you can remove
methods that data structures normally depend on without MRI breaking.