Add "Delete All" button to Retries in Web UI

[brandonhilkert]

Added "Delete All" button that leverages the API to clear jobs.

[jc00ke]

Nice! I'd prefer to see the button down by Retry Now and Delete, and I'd also prefer not to see the button if there are no jobs. Thoughts?

[bensie]

👍 How about a "Retry All" as well down there?

[brandonhilkert]

@jc00ke The position you mentioned was my first thought, but both of those buttons are controlled by the checkboxes, and something told me to put it somewhere else so that "Delete All" wasn't misinterpreted for "Delete All the ones on this page"? Does that make sense? My next thought was to maybe put it bottom left. Would that be better?

Agreed on not showing if there aren't jobs.

[jc00ke]

Maybe put buttons that are toggled by the checkboxes to the left (under the checkboxes) and Delete All/Retry All to the right?

[brandonhilkert]

@jc00ke Pushed.

Is "Retry All" something you'd like me to add as well?

[jc00ke]

@brandonhilkert re: Retry All @bensie had mentioned it, and if it's easy to add, might as well do it now.

Also, does that screencap reflect the changes? I was thinking...

Retries
__________________________________________________
|[]                                              |
|[]                                              |
|[]                                              |
|________________________________________________|
Retry Now   Delete                      Delete All

That way the buttons that are activated by the checkboxes are under the checkboxes.

[brandonhilkert]

Let me take a quick look at the Retry All.

re: pic - exactly. New screenshot is attached above.

[brandonhilkert]

Should be all set.

[brandonhilkert]

If this looks good, I can squash the commits if necessary. Let me know.

[bensie]

Looks awesome.

[mperham]

If there are 1000 retries, this will perform 1000 round trips. Just clear the sorted set in one go. I'd suggest adding a clear method to the API objects.

[brandonhilkert]

@mperham I might be missing something, but is there a good way to clear a sorted set rather than delete the key entirely?

[jc00ke]

Yeah, looks great. Once @mperham's suggestion about the clear method is implemented please squash then we'll merge.

[fabianoalmeida]

I'd like to suggest a little change... Why don't put Delete and Retry Now for each line of table?

For example, create a new column called Actions and put these two buttons there. Using this way, we won't need the column with checkboxes.

My suggestion makes more objective the actions. What do you think? Am I wrong with my point? ☺️

[brandonhilkert]

@fabianoalmeida You then lose the ability to delete, say 20, with a single button click. I see the benefit for a single job, but beyond that, the actions seem tedious.

[brandonhilkert]

@mperham How's that?

[brandonhilkert]

I also have a wiki page all setup for the API once this is merged.

[mperham]

Looks great, thanks!

[mperham]

Oh, changelog update?

[geomic]

This interface looks incredible @brandonhilkert - I personally can't wait till it makes it to master.

[brandonhilkert]

Updated changelog and rebased.