Skip to content

Adding moar badges#765

Merged
mperham merged 1 commit intosidekiq:masterfrom
krainboltgreene:patch-1
Mar 13, 2013
Merged

Adding moar badges#765
mperham merged 1 commit intosidekiq:masterfrom
krainboltgreene:patch-1

Conversation

@krainboltgreene
Copy link

Adding these badges:

  • Gem Version
  • Code Climate
  • Build Status
  • Dependency Status
  • Coverage Status

@krainboltgreene
Copy link
Author

Looks like sidekiq isn't using coveralls yet?

@mperham
Copy link
Collaborator

mperham commented Mar 12, 2013

I'm not sold on the utility of the badges. They seem to generate more busy work for me (update Gemfile, show spurious build errors, etc) rather than solve actual problems.

I'd be ok with rubygems, code climate and coveralls badges.

@krainboltgreene
Copy link
Author

Yeah, I'm still wobbly on the Gemnasium one. Maybe if it showed me if the library was behind security wise? Meh.

You already have travis, btw.

mperham added a commit that referenced this pull request Mar 13, 2013
@mperham mperham merged commit 23c4668 into sidekiq:master Mar 13, 2013
@mperham
Copy link
Collaborator

mperham commented Mar 13, 2013

I've turned on Coveralls but it needs to be integrated into the test suite. Someone want to do that?

@mperham
Copy link
Collaborator

mperham commented Mar 13, 2013

@krainboltgreene
Copy link
Author

I can do that.

@krainboltgreene krainboltgreene deleted the patch-1 branch March 13, 2013 21:14
@jc00ke
Copy link
Contributor

jc00ke commented Mar 13, 2013

I've got a branch with the changes that I'm testing now.

update: well that broke on travis... runs locally. Looks like coveralls didn't get installed... wtf?

@krainboltgreene
Copy link
Author

I just made a pull request with coveralls implemented, let me know if I
need to close it for yours, Jesse.

On Wed, Mar 13, 2013 at 2:19 PM, Jesse Cooke notifications@github.comwrote:

I've got a branch with the changes that I'm testing now.


Reply to this email directly or view it on GitHubhttps://github.com//pull/765#issuecomment-14869208
.

Kurtis Rainbolt-Greene, Hacker
Software Developer
612 S. Flower St.
Los Angeles, CA, 90017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants