Skip to content

fix(dap): dynamic library path setup fix#425

Merged
mrcjkb merged 3 commits intomrcjkb:masterfrom
morfnasilu:fix-dap-add-dynamic-library-path-macos-nightly
Jun 16, 2024
Merged

fix(dap): dynamic library path setup fix#425
mrcjkb merged 3 commits intomrcjkb:masterfrom
morfnasilu:fix-dap-add-dynamic-library-path-macos-nightly

Conversation

@morfnasilu
Copy link
Contributor

The PR fixes two small issues in the add_dynamic_library_paths method:

  1. Dynamic linking didn't work on macOS due to a typo in the DYLD_LIBRARY_PATH constant.
  2. Dynamic linking didn't work while using nightly toolchain (at least on macOS).

The problem was found when I tried to use rustaceanvim with Cargo.toml settings recommended for bevy engine: (https://bevyengine.org/learn/quick-start/getting-started/setup/).

FYI: Unfortunately I can't test that on systems.

@github-actions
Copy link
Contributor

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(lsp): some lsp-related bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (Steps to reproduce in PR description).
  • Updated documentation.
  • Updated CHANGELOG.md

Copy link
Owner

@mrcjkb mrcjkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks 🙏

@mrcjkb mrcjkb merged commit 368b614 into mrcjkb:master Jun 16, 2024
@mrcjkb
Copy link
Owner

mrcjkb commented Jun 16, 2024

I'll prepare a release later today 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants