Skip to content

feat(lsp): add cycle_prev arg to explainError and renderDiagnostic commands#761

Merged
mrcjkb merged 1 commit intomrcjkb:masterfrom
ebobrow:master
May 9, 2025
Merged

feat(lsp): add cycle_prev arg to explainError and renderDiagnostic commands#761
mrcjkb merged 1 commit intomrcjkb:masterfrom
ebobrow:master

Conversation

@ebobrow
Copy link
Contributor

@ebobrow ebobrow commented May 9, 2025

This adds a cycle_prev option to explainError and renderDiagnostic like vim.diagnostic.goto_prev.

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2025

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(lsp): some lsp-related bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (Steps to reproduce in PR description).
  • Updated documentation.

mrcjkb
mrcjkb previously approved these changes May 9, 2025
Copy link
Owner

@mrcjkb mrcjkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

Nice work!
Just one small suggestion.

@ebobrow
Copy link
Contributor Author

ebobrow commented May 9, 2025

Done, thanks!

@mrcjkb mrcjkb changed the title feat: add cycle_prev to explainError and renderDiagnostic feat(lsp): add cycle_prev arg to explainError and renderDiagnostic commands May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants