feat(lsp): experimental/localDocs support#808
Merged
mrcjkb merged 1 commit intomrcjkb:masterfrom Jul 14, 2025
Merged
Conversation
Contributor
Review ChecklistDoes this PR follow the Contribution Guidelines? Following is a partial checklist: Proper conventional commit scoping:
If applicable:
|
Owner
|
Will have to run the |
This was referenced Nov 3, 2025
This was referenced Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I opened #805 yesterday. Turns out, it's really not rocket science to implement.
I am worried about HTML URIs potentially being handled by a text editor, though.
Also, we're implicitly relying on outdated documentation for local types, as there's nothing that rebuilds it on save. It is still better than a 404 page, I think.
And I sure hope all 4 opening strategies can handle
file://identifiers.I couldn't properly run
luarockstests.