Skip to content

feat(lsp): experimental/localDocs support#808

Merged
mrcjkb merged 1 commit intomrcjkb:masterfrom
theammir:feature/localDocs
Jul 14, 2025
Merged

feat(lsp): experimental/localDocs support#808
mrcjkb merged 1 commit intomrcjkb:masterfrom
theammir:feature/localDocs

Conversation

@theammir
Copy link
Contributor

I opened #805 yesterday. Turns out, it's really not rocket science to implement.

I am worried about HTML URIs potentially being handled by a text editor, though.
Also, we're implicitly relying on outdated documentation for local types, as there's nothing that rebuilds it on save. It is still better than a 404 page, I think.
And I sure hope all 4 opening strategies can handle file:// identifiers.

I couldn't properly run luarocks tests.

@github-actions
Copy link
Contributor

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(lsp): some lsp-related bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (Steps to reproduce in PR description).
  • Updated documentation.

Copy link
Owner

@mrcjkb mrcjkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

Lgtm

@mrcjkb
Copy link
Owner

mrcjkb commented Jul 14, 2025

Will have to run the docgen hook when I'm on my laptop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants