feat: Add explicit type for better TypeScript errors on wrapped callbacks on Nitro views #1038
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply wraps the type for wrapped callbacks (
{ f: T }) in an explicit type, that improves TypeScript errors shown to the user, when a callback prop is not wrapped incallback(...)The typescript will therefore change slightly, allowing for a better developer experience:
Example: A
onMeasurementcallback prop onTtiMeasurementViewBefore
After
As seen above, the developer will now see an explicit
NitroViewWrappedCallbacktype, which the they can look up for further necessary steps.