Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mrousavy
force-pushed
the
docs/feedback
branch
from
736882c to
65894df
Compare
mrousavy
changed the title
HybridObject<{ ... }> platforms to docs
|
I need to start a YouTube-channel 😉 : #320 |
Owner
Author
|
hahaha yea valid - I guess at least in the landing pages we need the imports. Everywhere else it's incomplete code snippets |
|
Phew, thanks for adding -- I was confused the first day I tried making my own nitro modules |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some feedback I got from watching Oscar Franco try out Nitro Modules in
My code samples weren't always complete - sometimes they didn't contain the
HybridObject<P>Platform args, or sometimes they didn't include imports.So this PR improves that for many code samples:
+ import { type HybridObject } from 'react-native-nitro-modules' interface Math extends HybridObject<{ … }> {