From c9c5caa901f3da20c7f944be9765f83dddae1224 Mon Sep 17 00:00:00 2001 From: Daniel Markstedt Date: Wed, 20 Aug 2025 20:11:37 +0200 Subject: [PATCH 1/2] Record GitHub action versions in code comment Consistently keep track of the action version numbers, which will be recognized and kept updated by dependabot --- .github/workflows/build.yml | 36 ++++++++++++++++++------------------ 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index d7d10ab..dcd7d54 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -21,7 +21,7 @@ jobs: container: image: alpine:latest steps: - - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 + - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 - name: Install dependencies run: | apk add \ @@ -55,7 +55,7 @@ jobs: container: image: archlinux:latest steps: - - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 + - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 - name: Install dependencies run: | pacman -Sy --noconfirm \ @@ -85,7 +85,7 @@ jobs: container: image: debian:latest steps: - - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 + - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 - name: Install dependencies run: | apt-get update @@ -118,7 +118,7 @@ jobs: container: image: fedora:latest steps: - - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 + - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 - name: Install dependencies run: | dnf --setopt=install_weak_deps=False --assumeyes install \ @@ -148,7 +148,7 @@ jobs: runs-on: ubuntu-latest timeout-minutes: 2 steps: - - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 + - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 - name: Install dependencies run: | sudo apt-get update @@ -180,7 +180,7 @@ jobs: HOMEBREW_NO_INSTALL_CLEANUP: 1 HOMEBREW_NO_AUTO_UPDATE: 1 steps: - - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 + - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 - name: Install dependencies run: | brew update @@ -206,9 +206,9 @@ jobs: timeout-minutes: 10 steps: - name: Checkout repository - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 + uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 - name: Build on VM - uses: vmactions/dragonflybsd-vm@ff1f01c32b9e82f2ba388d0ff270442bcd6ceddc + uses: vmactions/dragonflybsd-vm@ff1f01c32b9e82f2ba388d0ff270442bcd6ceddc # v1.1.1 with: copyback: false usesh: true @@ -232,9 +232,9 @@ jobs: timeout-minutes: 10 steps: - name: Checkout repository - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 + uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 - name: Build on VM - uses: vmactions/freebsd-vm@966989c456d41351f095a421f60e71342d3bce41 + uses: vmactions/freebsd-vm@966989c456d41351f095a421f60e71342d3bce41 # v1.2.1 with: copyback: false prepare: | @@ -259,9 +259,9 @@ jobs: timeout-minutes: 10 steps: - name: Checkout repository - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 + uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 - name: Build on VM - uses: vmactions/netbsd-vm@46a58bbf03682b4cb24142b97fa315ae52bed573 + uses: vmactions/netbsd-vm@46a58bbf03682b4cb24142b97fa315ae52bed573 # v1.1.8 with: copyback: false prepare: | @@ -285,9 +285,9 @@ jobs: timeout-minutes: 10 steps: - name: Checkout repository - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 + uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 - name: Build on VM - uses: vmactions/openbsd-vm@1e7cc4fa7727646d3cf5921289b1f5c9d1a88f3c + uses: vmactions/openbsd-vm@1e7cc4fa7727646d3cf5921289b1f5c9d1a88f3c # v1.2.0 with: copyback: false prepare: | @@ -310,9 +310,9 @@ jobs: timeout-minutes: 10 steps: - name: Checkout repository - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 + uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 - name: Build on VM - uses: vmactions/omnios-vm@c31844c7abe722cd7c97df82cab1f1fab1e5339f + uses: vmactions/omnios-vm@c31844c7abe722cd7c97df82cab1f1fab1e5339f # v1.1.1 with: copyback: false prepare: | @@ -342,9 +342,9 @@ jobs: timeout-minutes: 12 steps: - name: Checkout repository - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 + uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 - name: Build on VM - uses: vmactions/solaris-vm@58cbd70c6e051860f9b8f65908cc582938fbbdba + uses: vmactions/solaris-vm@58cbd70c6e051860f9b8f65908cc582938fbbdba # v1.1.5 with: copyback: false prepare: | From d1a2c4e85d5c9b728c4746e4dcdfaef5584fb3da Mon Sep 17 00:00:00 2001 From: Daniel Markstedt Date: Wed, 20 Aug 2025 20:15:32 +0200 Subject: [PATCH 2/2] Remove timeouts in GitHub workflow jobs The vmactions runners have been improved with retry logic, so let's remove the timeouts for now --- .github/workflows/build.yml | 12 ------------ .github/workflows/test.yml | 1 - 2 files changed, 13 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index dcd7d54..a7b0200 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -17,7 +17,6 @@ jobs: build-alpine: name: Alpine Linux runs-on: ubuntu-latest - timeout-minutes: 2 container: image: alpine:latest steps: @@ -51,7 +50,6 @@ jobs: build-archlinux: name: Arch Linux runs-on: ubuntu-latest - timeout-minutes: 2 container: image: archlinux:latest steps: @@ -81,7 +79,6 @@ jobs: build-debian: name: Debian Linux runs-on: ubuntu-latest - timeout-minutes: 2 container: image: debian:latest steps: @@ -114,7 +111,6 @@ jobs: build-fedora: name: Fedora Linux runs-on: ubuntu-latest - timeout-minutes: 2 container: image: fedora:latest steps: @@ -146,7 +142,6 @@ jobs: build-ubuntu: name: Ubuntu Linux runs-on: ubuntu-latest - timeout-minutes: 2 steps: - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 - name: Install dependencies @@ -175,7 +170,6 @@ jobs: build-macos: name: macOS runs-on: macos-latest - timeout-minutes: 2 env: HOMEBREW_NO_INSTALL_CLEANUP: 1 HOMEBREW_NO_AUTO_UPDATE: 1 @@ -203,7 +197,6 @@ jobs: build-dflybsd: name: DragonflyBSD runs-on: ubuntu-latest - timeout-minutes: 10 steps: - name: Checkout repository uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 @@ -229,7 +222,6 @@ jobs: build-freebsd: name: FreeBSD runs-on: ubuntu-latest - timeout-minutes: 10 steps: - name: Checkout repository uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 @@ -256,7 +248,6 @@ jobs: build-netbsd: name: NetBSD runs-on: ubuntu-latest - timeout-minutes: 10 steps: - name: Checkout repository uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 @@ -282,7 +273,6 @@ jobs: build-openbsd: name: OpenBSD runs-on: ubuntu-latest - timeout-minutes: 10 steps: - name: Checkout repository uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 @@ -307,7 +297,6 @@ jobs: build-omnios: name: OmniOS runs-on: ubuntu-latest - timeout-minutes: 10 steps: - name: Checkout repository uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 @@ -339,7 +328,6 @@ jobs: build-solaris: name: Solaris runs-on: ubuntu-latest - timeout-minutes: 12 steps: - name: Checkout repository uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 7044dcd..db6da04 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -20,7 +20,6 @@ jobs: permissions: checks: write pull-requests: write - timeout-minutes: 2 steps: - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 - name: Install dependencies