fix: normalize sizes for same-name deps

Author: my4ng

examples/pugio.svg

@@ -34,11 +34,22 @@ impl NodeWeight {
     }
 }
 
+pub fn normalize_sizes(graph: &StableGraph<NodeWeight, ()>, map: &mut HashMap<String, usize>) {
+    let mut counts = HashMap::with_capacity(graph.node_count());
+    for node in graph.node_weights() {
+        *counts.entry(node.short()).or_default() += 1;
+    }
+
+    for (name, size) in map.iter_mut() {
+        let count = counts.get(name.as_str()).copied().unwrap_or(1);
+        *size /= count;
+    }
+}
+
 pub fn cum_sums(
     graph: &StableGraph<NodeWeight, ()>,
     map: &HashMap<String, usize>,
 ) -> (Vec<usize>, f32) {
-    // TODO: currently the same size is used for all nodes with the same name, change?
     let mut cum_sums = vec![0; graph.capacity().0];
 
     for (idx, size) in graph.node_indices().filter_map(|i| {

src/graph.rs

@@ -9,8 +9,8 @@ use crate::{
     config::Config,
     dot::{output_dot, output_svg},
     graph::{
-        NodeWeight, change_root, cum_sums, dep_counts, remove_deep_deps, remove_excluded_deps,
-        remove_small_deps, rev_dep_counts,
+        NodeWeight, change_root, cum_sums, dep_counts, normalize_sizes, remove_deep_deps,
+        remove_excluded_deps, remove_small_deps, rev_dep_counts,
     },
     template::get_templates,
 };
@@ -127,7 +127,9 @@ fn main() -> anyhow::Result<()> {
     let mut graph = get_dep_graph(&tree_output).context("failed to parse cargo-tree output")?;
 
     let bloat_output = cargo_bloat_output(&options)?;
-    let size_map = get_size_map(&bloat_output).context("failed to parse cargo-bloat output")?;
+    let mut size_map = get_size_map(&bloat_output).context("failed to parse cargo-bloat output")?;
+
+    normalize_sizes(&graph, &mut size_map);
 
     let mut root_idx = petgraph::graph::NodeIndex::new(0);