Merge pull request #4614 from anoma/mergify/bp/maint-libs-0.149/pr-4566

Test masp events (backport #4566)

Author: mergify[bot]

.changelog/unreleased/testing/4566-test-masp-events.md

@@ -0,0 +1,2 @@
+- Added integration tests to cover the new MASP events and masp fee payments in
+  a failing atomic batch. ([\#4566](https://github.com/anoma/namada/pull/4566))

crates/node/src/shell/testing/node.rs

@@ -530,16 +530,16 @@ impl MockNode {
         let mut result_codes = resp
             .events
             .iter()
-            .map(|e| {
-                let code = e
-                    .read_attribute_opt::<CodeAttr>()
+            .filter_map(|e| {
+                e.read_attribute_opt::<CodeAttr>()
                     .unwrap()
-                    .unwrap_or_default();
-                if code == ResultCode::Ok {
-                    NodeResults::Ok
-                } else {
-                    NodeResults::Failed(code)
-                }
+                    .map(|result_code| {
+                        if result_code == ResultCode::Ok {
+                            NodeResults::Ok
+                        } else {
+                            NodeResults::Failed(result_code)
+                        }
+                    })
             })
             .collect::<Vec<_>>();
         let mut tx_results = resp
@@ -675,16 +675,16 @@ impl MockNode {
         let mut error_codes = resp
             .events
             .iter()
-            .map(|e| {
-                let code = e
-                    .read_attribute_opt::<CodeAttr>()
+            .filter_map(|e| {
+                e.read_attribute_opt::<CodeAttr>()
                     .unwrap()
-                    .unwrap_or_default();
-                if code == ResultCode::Ok {
-                    NodeResults::Ok
-                } else {
-                    NodeResults::Failed(code)
-                }
+                    .map(|result_code| {
+                        if result_code == ResultCode::Ok {
+                            NodeResults::Ok
+                        } else {
+                            NodeResults::Failed(result_code)
+                        }
+                    })
             })
             .collect::<Vec<_>>();
         let mut txs_results = resp