Skip to content

Bugfix/issue 107 fix bitbucked url parse#118

Merged
protoroto merged 8 commits into
nephila:masterfrom
taminomara:bugfix/issue-107-fix-bitbucked-url-parse
Oct 22, 2025
Merged

Bugfix/issue 107 fix bitbucked url parse#118
protoroto merged 8 commits into
nephila:masterfrom
taminomara:bugfix/issue-107-fix-bitbucked-url-parse

Conversation

@taminomara
Copy link
Copy Markdown
Contributor

Description

This fixes the BitBucket regex so username@ is not required, and adds bitbucket.com as a recognised domain.

References

Fixes #107. The original PR is #108 by @mathrick.

Checklist

  • Code lint checked via inv lint
  • Tests added

@taminomara taminomara mentioned this pull request Oct 21, 2025
2 tasks
Copy link
Copy Markdown

@ivs-cetmix ivs-cetmix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread changes/107.bugfix Outdated
@coveralls
Copy link
Copy Markdown

coveralls commented Oct 22, 2025

Pull Request Test Coverage Report for Build 18709957631

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 95.833%

Totals Coverage Status
Change from base Build 18709799519: 0.02%
Covered Lines: 215
Relevant Lines: 225

💛 - Coveralls

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@b9f7d15). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #118   +/-   ##
=========================================
  Coverage          ?   94.66%           
=========================================
  Files             ?       12           
  Lines             ?      225           
  Branches          ?       29           
=========================================
  Hits              ?      213           
  Misses            ?       10           
  Partials          ?        2           
Flag Coverage Δ
unittests 94.66% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-authored-by: Leonardo Cavallucci <leo.cavallucci@gmail.com>
@protoroto protoroto merged commit 4db5dc6 into nephila:master Oct 22, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BitBucket URLs are detected as gitlab

5 participants