feat: Updating to SDK v0.17.0

Author: ashchan

packages/neuron-ui/package.json

@@ -43,7 +43,7 @@
     "last 2 chrome versions"
   ],
   "dependencies": {
-    "@nervosnetwork/ckb-sdk-core": "0.16.0",
+    "@nervosnetwork/ckb-sdk-core": "0.17.0",
     "@uifabric/experiments": "7.4.2",
     "@uifabric/styling": "7.1.1",
     "canvg": "2.0.0",

packages/neuron-wallet/package.json

@@ -34,8 +34,8 @@
     ]
   },
   "dependencies": {
-    "@nervosnetwork/ckb-sdk-core": "0.16.0",
-    "@nervosnetwork/ckb-sdk-utils": "0.16.0",
+    "@nervosnetwork/ckb-sdk-core": "0.17.0",
+    "@nervosnetwork/ckb-sdk-utils": "0.17.0",
     "async": "3.0.1",
     "bn.js": "4.11.8",
     "chalk": "2.4.2",
@@ -52,7 +52,7 @@
     "winston": "3.2.1"
   },
   "devDependencies": {
-    "@nervosnetwork/ckb-types": "0.16.0",
+    "@nervosnetwork/ckb-types": "0.17.0",
     "@types/async": "3.0.0",
     "@types/electron-devtools-installer": "2.2.0",
     "@types/elliptic": "6.4.8",

packages/neuron-wallet/src/models/keys/address.ts

@@ -1,4 +1,4 @@
-import { AddressPrefix, AddressType as Type, AddressBinIdx, pubkeyToAddress } from '@nervosnetwork/ckb-sdk-utils'
+import { AddressPrefix, AddressType as Type, pubkeyToAddress } from '@nervosnetwork/ckb-sdk-utils'
 
 import { AccountExtendedPublicKey } from './key'
 
@@ -12,8 +12,8 @@ export enum AddressType {
 export const publicKeyToAddress = (publicKey: string, prefix = AddressPrefix.Testnet) =>
   pubkeyToAddress(publicKey, {
     prefix,
-    type: Type.BinIdx,
-    binIdx: AddressBinIdx.P2PH,
+    type: Type.HashIdx,
+    codeHashIndex: '0x00',
   })
 
 export default class Address {

packages/neuron-wallet/src/models/lock-utils.ts

@@ -112,8 +112,8 @@ export default class LockUtils {
     const prefix = env.testnet ? core.utils.AddressPrefix.Testnet : core.utils.AddressPrefix.Mainnet
     return core.utils.bech32Address(blake160, {
       prefix,
-      type: core.utils.AddressType.BinIdx,
-      binIdx: core.utils.AddressBinIdx.P2PH,
+      type: core.utils.AddressType.HashIdx,
+      codeHashIndex: '0x00',
     })
   }
 

packages/neuron-wallet/src/types/cell-types.ts

@@ -75,4 +75,5 @@ export interface CellOutPoint {
 export interface Script {
   args?: string[]
   codeHash?: string | null
+  hashType: string
 }

packages/neuron-wallet/tests/database/address/dao.test.ts

@@ -6,7 +6,7 @@ import AddressDao, { Address } from '../../../src/database/address/dao'
 describe('Address Dao tests', () => {
   const address: Address = {
     walletId: '1',
-    address: 'ckt1q9gry5zgxmpjnmtrp4kww5r39frh2sm89tdt2l6v234ygf',
+    address: 'ckt1qyqrdsefa43s6m882pcj53m4gdnj4k440axqswmu83',
     path: "m/44'/309'/0'/0/0",
     addressType: AddressType.Receiving,
     addressIndex: 0,
@@ -21,7 +21,7 @@ describe('Address Dao tests', () => {
 
   const usedAddress: Address = {
     walletId: '2',
-    address: 'ckt1q9gry5zgxmpjnmtrp4kww5r39frh2sm89tdt2l6v234ygf',
+    address: 'ckt1qyqrdsefa43s6m882pcj53m4gdnj4k440axqswmu83',
     path: "m/44'/309'/0'/0/0",
     addressType: AddressType.Receiving,
     addressIndex: 0,

packages/neuron-wallet/tests/models/keys/address.test.ts

@@ -17,19 +17,19 @@ describe('address', () => {
     const publicKey = '0x024a501efd328e062c8675f2365970728c859c592beeefd6be8ead3d901330bc01'
     const path = `m/44'/309'/0'/0/0`
     const address = Address.fromPublicKey(publicKey, `m/44'/309'/0'/0/0`)
-    expect(address.address).toEqual('ckt1q9gry5zgxmpjnmtrp4kww5r39frh2sm89tdt2l6v234ygf')
+    expect(address.address).toEqual('ckt1qyqrdsefa43s6m882pcj53m4gdnj4k440axqswmu83')
     expect(address.path).toEqual(path)
   })
 
   it('Generate testnet address from public key', () => {
     const publicKey = '0x024a501efd328e062c8675f2365970728c859c592beeefd6be8ead3d901330bc01'
     const address = publicKeyToAddress(publicKey)
-    expect('ckt1q9gry5zgxmpjnmtrp4kww5r39frh2sm89tdt2l6v234ygf').toBe(address)
+    expect('ckt1qyqrdsefa43s6m882pcj53m4gdnj4k440axqswmu83').toBe(address)
   })
 
   it('Generate mainnet address from public key', () => {
     const publicKey = '0x024a501efd328e062c8675f2365970728c859c592beeefd6be8ead3d901330bc01'
     const address = publicKeyToAddress(publicKey, AddressPrefix.Mainnet)
-    expect('ckb1q9gry5zgxmpjnmtrp4kww5r39frh2sm89tdt2l6vqdd7em').toBe(address)
+    expect('ckb1qyqrdsefa43s6m882pcj53m4gdnj4k440axqdt9rtd').toBe(address)
   })
 })

packages/neuron-wallet/tests/models/lock-utils.test.ts

@@ -19,7 +19,7 @@ describe('LockUtils Test', () => {
       args: ['0x36c329ed630d6ce750712a477543672adab57f4c'],
     },
     lockHash: '0x3dbdeb3538b7abe1b1f85a86b150805728c29b26faceb5051fb6c7f92c346ed8',
-    address: 'ckt1q9gry5zgxmpjnmtrp4kww5r39frh2sm89tdt2l6v234ygf',
+    address: 'ckt1qyqrdsefa43s6m882pcj53m4gdnj4k440axqswmu83',
     blake160: '0x36c329ed630d6ce750712a477543672adab57f4c',
   }
 

packages/neuron-wallet/tests/services/address.test.ts

@@ -17,12 +17,12 @@ describe('Key tests', () => {
 
     expect(2).toBe(addresses.testnetReceiving.length)
     expect("m/44'/309'/0'/0/0").toBe(addresses.testnetReceiving[0].path)
-    expect('ckt1q9gry5zgqt5rp0t0uxv39lahkzcnfjl9x9utn683yv9zxs').toBe(addresses.testnetReceiving[0].address)
+    expect('ckt1qyqq96psh4h7rxgjl7mmpvf5e0jnz79earcsyrlxrx').toBe(addresses.testnetReceiving[0].address)
 
     // will include testnet address and mainnet address, [0] and [1] will be same
     expect(2).toBe(addresses.testnetChange.length)
     expect("m/44'/309'/0'/1/1").toBe(addresses.testnetChange[1].path)
-    expect('ckt1q9gry5zg7r0qgqc3vnvy8pwr0q8mkgvgywfjazg9xlz2ev').toBe(addresses.testnetChange[1].address)
+    expect('ckt1qyq0phsyqvgkfkzrshphsramyxyz8yew3yzsl76naf').toBe(addresses.testnetChange[1].address)
   })
 
   it('toAddress', () => {
@@ -45,7 +45,7 @@ describe('Key tests', () => {
 describe('Key tests with db', () => {
   const address: Address = {
     walletId: '1',
-    address: 'ckt1q9gry5zgxmpjnmtrp4kww5r39frh2sm89tdt2l6v234ygf',
+    address: 'ckt1qyqrdsefa43s6m882pcj53m4gdnj4k440axqswmu83',
     path: "m/44'/309'/0'/0/0",
     addressType: AddressType.Receiving,
     addressIndex: 0,
@@ -60,7 +60,7 @@ describe('Key tests with db', () => {
 
   const usedAddress: Address = {
     walletId: '2',
-    address: 'ckt1q9gry5zgxmpjnmtrp4kww5r39frh2sm89tdt2l6v234ygf',
+    address: 'ckt1qyqrdsefa43s6m882pcj53m4gdnj4k440axqswmu83',
     path: "m/44'/309'/0'/0/0",
     addressType: AddressType.Receiving,
     addressIndex: 0,

packages/neuron-wallet/tests/services/transactions.test.ts

@@ -3,7 +3,7 @@ import TransactionsService, { SearchType } from '../../src/services/transactions
 describe('transactions service', () => {
   describe('filterSearchType', () => {
     it('ckt prefix', () => {
-      const address = 'ckt1q9gry5zgxmpjnmtrp4kww5r39frh2sm89tdt2l6v234ygf'
+      const address = 'ckt1qyqrdsefa43s6m882pcj53m4gdnj4k440axqswmu83'
       const type = TransactionsService.filterSearchType(address)
       expect(type).toBe(SearchType.Address)
     })