From 9d93935b76cf8064e979fde4303da2f60d689bd8 Mon Sep 17 00:00:00 2001
From: Keith <keithwhisper@gmail.com>
Date: Mon, 9 Sep 2019 13:23:36 +0800
Subject: [PATCH] chore(neuron-ui): clean eslint warnings

---
 packages/neuron-ui/.eslintrc.js                           | 7 ++++++-
 packages/neuron-ui/src/components/ErrorBoundary/index.tsx | 8 +++++---
 .../src/services/remote/controllerMethodWrapper.ts        | 2 --
 packages/neuron-ui/src/services/remote/index.ts           | 2 --
 packages/neuron-ui/src/states/stateProvider/reducer.ts    | 2 --
 packages/neuron-ui/src/utils/formatters.ts                | 3 ---
 packages/neuron-ui/src/utils/validators.ts                | 2 --
 7 files changed, 11 insertions(+), 15 deletions(-)

diff --git a/packages/neuron-ui/.eslintrc.js b/packages/neuron-ui/.eslintrc.js
index 66dc533393..c65f0bdcbc 100644
--- a/packages/neuron-ui/.eslintrc.js
+++ b/packages/neuron-ui/.eslintrc.js
@@ -11,6 +11,11 @@ module.exports = {
     "react/jsx-filename-extension": [1, {
       "extensions": [".ts", ".tsx"]
     }],
-    "react/jsx-props-no-spreading": [0]
+    "react/jsx-props-no-spreading": [0],
+    "typescript-eslint/no-angle-bracket-type-assertion": [0],
+    "no-alert": [0],
+    "no-console": [2, {
+      "allow": ["info", "warn", "error", "group", "groupEnd"]
+    }]
   }
 }
diff --git a/packages/neuron-ui/src/components/ErrorBoundary/index.tsx b/packages/neuron-ui/src/components/ErrorBoundary/index.tsx
index a8867ad82d..df3c8226a1 100644
--- a/packages/neuron-ui/src/components/ErrorBoundary/index.tsx
+++ b/packages/neuron-ui/src/components/ErrorBoundary/index.tsx
@@ -9,9 +9,11 @@ const handleError = (error: Error) => {
 }
 
 class ErrorBoundary extends Component<{ children: React.ReactChild }, { hasError: boolean }> {
-  /* eslint-disable react/state-in-constructor */
-  state = {
-    hasError: false,
+  constructor(props: { children: React.ReactChild }) {
+    super(props)
+    this.state = {
+      hasError: false,
+    }
   }
 
   static getDerivedStateFromError(error: Error) {
diff --git a/packages/neuron-ui/src/services/remote/controllerMethodWrapper.ts b/packages/neuron-ui/src/services/remote/controllerMethodWrapper.ts
index b44a7f8a6b..6bb884f9af 100644
--- a/packages/neuron-ui/src/services/remote/controllerMethodWrapper.ts
+++ b/packages/neuron-ui/src/services/remote/controllerMethodWrapper.ts
@@ -48,11 +48,9 @@ export const controllerMethodWrapper = (controllerName: string) => (
   }
   const res = await callControllerMethod(controller)(realParams)
   if (process.env.NODE_ENV === 'development' && window.localStorage.getItem('log-response')) {
-    /* eslint-disable no-console */
     console.group(`${controllerName} controller`)
     console.info(JSON.stringify(res, null, 2))
     console.groupEnd()
-    /* eslint-enable no-console */
   }
 
   if (!res) {
diff --git a/packages/neuron-ui/src/services/remote/index.ts b/packages/neuron-ui/src/services/remote/index.ts
index ba1171e57e..fff8b2c7ca 100644
--- a/packages/neuron-ui/src/services/remote/index.ts
+++ b/packages/neuron-ui/src/services/remote/index.ts
@@ -3,8 +3,6 @@ export * from './wallets'
 export * from './networks'
 export * from './transactions'
 
-/* eslint-disable no-alert */
-
 export const getLocale = () => {
   if (!window.remote) {
     console.warn('remote is not supported')
diff --git a/packages/neuron-ui/src/states/stateProvider/reducer.ts b/packages/neuron-ui/src/states/stateProvider/reducer.ts
index 5f46e9be86..5e4020a656 100644
--- a/packages/neuron-ui/src/states/stateProvider/reducer.ts
+++ b/packages/neuron-ui/src/states/stateProvider/reducer.ts
@@ -62,11 +62,9 @@ export const reducer = (
 ): State.AppWithNeuronWallet => {
   const { app, wallet, settings, chain } = state
   if (process.env.NODE_ENV === 'development' && window.localStorage.getItem('log-action')) {
-    /* eslint-disable no-console */
     console.group(`type: ${type}`)
     console.info(payload)
     console.groupEnd()
-    /* eslint-enable no-console */
   }
   switch (type) {
     // Actions of Neuron Wallet
diff --git a/packages/neuron-ui/src/utils/formatters.ts b/packages/neuron-ui/src/utils/formatters.ts
index 886dd71ea5..ced652e53e 100644
--- a/packages/neuron-ui/src/utils/formatters.ts
+++ b/packages/neuron-ui/src/utils/formatters.ts
@@ -1,6 +1,3 @@
-/* eslint-disable no-redeclare */
-/* global BigInt */
-
 import { CapacityUnit } from './const'
 
 const base = 10e9
diff --git a/packages/neuron-ui/src/utils/validators.ts b/packages/neuron-ui/src/utils/validators.ts
index 8d6bab4029..bf1c0a26ad 100644
--- a/packages/neuron-ui/src/utils/validators.ts
+++ b/packages/neuron-ui/src/utils/validators.ts
@@ -1,6 +1,4 @@
 import { MAX_NETWORK_NAME_LENGTH } from 'utils/const'
-/* eslint-disable no-redeclare */
-/* global BigInt */
 import { ckbCore } from 'services/chain'
 import { MIN_PASSWORD_LENGTH, MAX_PASSWORD_LENGTH, MIN_AMOUNT, MAX_DECIMAL_DIGITS, ErrorCode } from './const'