Skip to content

[stable32] fix(ExAppNotifier): First check if any exapps enabled #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcelklehr merged 2 commits into from
Oct 7, 2025
Merged

[stable32] fix(ExAppNotifier): First check if any exapps enabled #680

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5ec16d
fix(ExAppNotifier): First check if any exapps enabled
marcelklehr Jul 17, 2025
f1adee0
fix(ExAppNotifier): Use empty() instead of count()
marcelklehr Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix(ExAppNotifier): Use empty() instead of count() 
more performant

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
  • Loading branch information
@marcelklehr @backportbot
marcelklehr authored and backportbot[bot] committed Oct 6, 2025
commit f1adee0d99595f76a513321bed2c12f104edf6f5
2 changes: 1 addition & 1 deletion lib/Notifications/ExAppNotifier.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public function getName(): string {
}

public function prepare(INotification $notification, string $languageCode): INotification {
if (count($this->service->getExAppsList()) === 0) {
if (empty($this->service->getExAppsList())) {
throw new UnknownNotificationException();
}
$exApp = $this->service->getExApp($notification->getApp());
Expand Down