Skip to content

Commit 0d749b7

Browse files
committed
Remove iconv from dependencies and tests
which is not used anymore since: #29470 Signed-off-by: MichaIng <micha@dietpi.com>
1 parent 393ea92 commit 0d749b7

File tree

5 files changed

+4
-9
lines changed

5 files changed

+4
-9
lines changed

.github/workflows/oci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ jobs:
4040
uses: shivammathur/setup-php@v2
4141
with:
4242
php-version: ${{ matrix.php-versions }}
43-
extensions: ctype,curl,dom,fileinfo,gd,iconv,imagick,intl,json,mbstring,oci8,openssl,pdo_sqlite,posix,sqlite,xml,zip
43+
extensions: ctype,curl,dom,fileinfo,gd,imagick,intl,json,mbstring,oci8,openssl,pdo_sqlite,posix,sqlite,xml,zip
4444
tools: phpunit:9
4545
coverage: none
4646

.github/workflows/s3-external.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ jobs:
4545
with:
4646
php-version: ${{ matrix.php-versions }}
4747
tools: phpunit
48-
extensions: mbstring, iconv, fileinfo, intl, sqlite, pdo_sqlite, zip, gd
48+
extensions: mbstring, fileinfo, intl, sqlite, pdo_sqlite, zip, gd
4949

5050
- name: Set up Nextcloud
5151
run: |
@@ -94,7 +94,7 @@ jobs:
9494
with:
9595
php-version: ${{ matrix.php-versions }}
9696
tools: phpunit
97-
extensions: mbstring, iconv, fileinfo, intl, sqlite, pdo_sqlite, zip, gd
97+
extensions: mbstring, fileinfo, intl, sqlite, pdo_sqlite, zip, gd
9898

9999
- name: Set up Nextcloud
100100
run: |

.github/workflows/update-psalm-baseline.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
uses: shivammathur/setup-php@v2
1919
with:
2020
php-version: 7.4
21-
extensions: ctype,curl,dom,fileinfo,gd,iconv,intl,json,mbstring,openssl,pdo_sqlite,posix,sqlite,xml,zip
21+
extensions: ctype,curl,dom,fileinfo,gd,intl,json,mbstring,openssl,pdo_sqlite,posix,sqlite,xml,zip
2222
coverage: none
2323

2424
- name: Composer install

lib/private/App/PlatformRepository.php

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,10 +65,6 @@ protected function initialize() {
6565
$prettyVersion = $curlVersion['version'];
6666
break;
6767

68-
case 'iconv':
69-
$prettyVersion = ICONV_VERSION;
70-
break;
71-
7268
case 'intl':
7369
$name = 'ICU';
7470
if (defined('INTL_ICU_VERSION')) {

lib/private/legacy/OC_Util.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -837,7 +837,6 @@ public static function checkServer(\OC\SystemConfig $config) {
837837
'json_encode' => 'JSON',
838838
'gd_info' => 'GD',
839839
'gzencode' => 'zlib',
840-
'iconv' => 'iconv',
841840
'simplexml_load_string' => 'SimpleXML',
842841
'hash' => 'HASH Message Digest Framework',
843842
'curl_init' => 'cURL',

0 commit comments

Comments
 (0)