feat: cleanup filecache_extended items by default

Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Author: icewind1991

apps/files/lib/Command/DeleteOrphanedFiles.php

@@ -47,7 +47,7 @@ protected function configure(): void {
 		$this
 			->setName('files:cleanup')
 			->setDescription('cleanup filecache')
-			->addOption('filecache-extended', null, InputOption::VALUE_NONE, 'remove orphaned entries from filecache_extended');
+			->addOption('skip-filecache-extended', null, InputOption::VALUE_NONE, 'don\'t remove orphaned entries from filecache_extended');
 	}
 
 	public function execute(InputInterface $input, OutputInterface $output): int {
@@ -78,7 +78,7 @@ public function execute(InputInterface $input, OutputInterface $output): int {
 
 		$output->writeln("$deletedEntries orphaned file cache entries deleted");
 
-		if ($input->getOption('filecache-extended')) {
+		if (!$input->getOption('skip-filecache-extended')) {
 			$deletedFileCacheExtended = $this->cleanupOrphanedFileCacheExtended();
 			$output->writeln("$deletedFileCacheExtended orphaned file cache extended entries deleted");
 		}

apps/files/tests/Command/DeleteOrphanedFilesTest.php

@@ -132,10 +132,11 @@ public function testClearFiles() {
 
 		// parent folder, `files`, ´test` and `welcome.txt` => 4 elements
 		$output
-			->expects($this->exactly(2))
+			->expects($this->exactly(3))
 			->method('writeln')
 			->withConsecutive(
 				['3 orphaned file cache entries deleted'],
+				['0 orphaned file cache extended entries deleted'],
 				['1 orphaned mount entries deleted'],
 			);