Skip to content

Commit 54486d1

Browse files
committed
fix(files_external): check for changes when saving settings
Signed-off-by: Enjeck C <patrathewhiz@gmail.com>
1 parent 72dd55e commit 54486d1

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

apps/files_external/src/settings.js

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -554,6 +554,8 @@ MountOptionsDropdown.prototype = {
554554
this.setOptions(mountOptions, visibleOptions, storage)
555555

556556
this.$el.appendTo($container)
557+
558+
this._initialOptions = JSON.stringify(this.getOptions())
557559
MountOptionsDropdown._last = this
558560

559561
this.$el.trigger('show')
@@ -1464,11 +1466,14 @@ MountConfigListView.prototype = _.extend({
14641466
})
14651467

14661468
dropDown.$el.on('hide', function() {
1467-
const mountOptions = dropDown.getOptions()
1469+
const newOptions = dropDown.getOptions()
1470+
const newOptionsStr = JSON.stringify(newOptions)
14681471
$('body').off('mouseup.mountOptionsDropdown')
1469-
$tr.find('input.mountOptions').val(JSON.stringify(mountOptions))
14701472
$tr.find('td.mountOptionsToggle>.icon-more').attr('aria-expanded', 'false')
1471-
self.saveStorageConfig($tr)
1473+
if (dropDown._initialOptions !== newOptionsStr) {
1474+
$tr.find('input.mountOptions').val(newOptionsStr)
1475+
self.saveStorageConfig($tr)
1476+
}
14721477
})
14731478
},
14741479
}, OC.Backbone.Events)

0 commit comments

Comments
 (0)