Skip to content

Commit 6896724

Browse files
committed
Handle error in previews for files versions
Signed-off-by: Louis Chemineau <louis@chmn.me>
1 parent 02807a3 commit 6896724

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

apps/files_versions/src/components/Version.vue

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,15 @@
2424
@click="click">
2525
<template #icon>
2626
<div v-if="!(loadPreview || previewLoaded)" class="version__image" />
27-
<img v-else-if="isCurrent || version.hasPreview"
27+
<img v-else-if="(isCurrent || version.hasPreview) && !previewErrored"
2828
:src="version.previewUrl"
2929
alt=""
3030
decoding="async"
3131
fetchpriority="low"
3232
loading="lazy"
3333
class="version__image"
34-
@load="previewLoaded = true">
34+
@load="previewLoaded = true"
35+
@error="previewErrored = true">
3536
<div v-else
3637
class="version__image">
3738
<ImageOffOutline :size="20" />
@@ -212,6 +213,7 @@ export default {
212213
data() {
213214
return {
214215
previewLoaded: false,
216+
previewErrored: false,
215217
showVersionLabelForm: false,
216218
formVersionLabelValue: this.version.label,
217219
capabilities: loadState('core', 'capabilities', { files: { version_labeling: false, version_deletion: false } }),

dist/files_versions-files_versions.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/files_versions-files_versions.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)