Merge pull request #44676 from jadjoud/fix#44487and#44488

susnux · web-flow · commit 6b3058747ceb · 2024-04-08T13:31:27.000+02:00
fix overlay of oc-dialog
diff --git a/core/src/jquery/css/jquery.ocdialog.scss b/core/src/jquery/css/jquery.ocdialog.scss
@@ -4,7 +4,7 @@
 	border-radius: var(--border-radius-large);
 	box-shadow: 0 0 30px var(--color-box-shadow);
 	padding: 24px;
-	z-index: 10000;
+	z-index: 100001;
 	font-size: 100%;
 	box-sizing: border-box;
 	min-width: 200px;
@@ -69,7 +69,7 @@
 .oc-dialog-dim {
 	background-color: #000;
 	opacity: .2;
-	z-index: 9999;
+	z-index: 100001;
 	position: fixed;
 	top: 0;
 	left: 0;
diff --git a/core/src/jquery/ocdialog.js b/core/src/jquery/ocdialog.js
@@ -234,7 +234,7 @@ $.widget('oc.ocdialog', {
 		}
 		this.overlay = $('<div>')
 			.addClass('oc-dialog-dim')
-			.appendTo(contentDiv)
+			.insertBefore(this.$dialog)
 		this.overlay.on('click keydown keyup', function(event) {
 			if (event.target !== self.$dialog.get(0) && self.$dialog.find($(event.target)).length === 0) {
 				event.preventDefault()

Original file line number	Diff line number	Diff line change
`@@ -234,7 +234,7 @@ $.widget('oc.ocdialog', {`
`234`	`234`	`}`
`235`	`235`	`this.overlay = $('<div>')`
`236`	`236`	`.addClass('oc-dialog-dim')`
`237`		`- .appendTo(contentDiv)`
	`237`	`+ .insertBefore(this.$dialog)`
`238`	`238`	`this.overlay.on('click keydown keyup', function(event) {`
`239`	`239`	`if (event.target !== self.$dialog.get(0) && self.$dialog.find($(event.target)).length === 0) {`
`240`	`240`	`event.preventDefault()`