Update acceptance tests to Selenium 3

The acceptance tests used the last Selenium 2 Docker container
available, which provides a rather old Firefox version (Firefox 47).
Nevertheless, despite some rendering issues, most things still worked as
expected due to the JavaScript files being built with support for older
browsers. However, now that support for Internet Explorer 11 and older
browsers will be dropped things could start to fail, so a newer browser
(and thus a newer Selenium version) should be used in the acceptance
tests.

Selenium has been standardized by the W3C, and the protocol to
communicate between the Selenium server and the browser has changed due
to that. Firefox >= 48 only supports the new W3C protocol, but the
Selenium driver for Mink does not support it yet.

The old protocol can still be used in recent Chromium/Chrome versions by
explicitly forcing it, so for the time being the acceptance tests will
need to be run on Chrome instead (although Firefox provides some
interesting features like the fake streams that would be needed to test
calls in Talk, so they should be moved again to Firefox once possible).

Finally, the default shm size of Docker is 64 MiB. This does not seem
enough to run newer Chromium releases and causes the browser to randomly
crash during the tests ("unknown error: session deleted because of page
crash" is shown in the logs), so a larger size (256 MiB) needs to be
used instead.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Author: danxuliu

.drone.yml

@@ -1684,7 +1684,7 @@ steps:
 
 services:
 - name: selenium
-  image: selenium/standalone-firefox:2.53.1-beryllium
+  image: selenium/standalone-chrome:3.141.59
   environment:
     # Reduce default log level for Selenium server (INFO) as it is too
     # verbose.
@@ -1714,7 +1714,7 @@ trigger:
 #
 #services:
 #- name: selenium
-#  image: selenium/standalone-firefox:2.53.1-beryllium
+#  image: selenium/standalone-chrome:3.141.59
 #  environment:
 #    # Reduce default log level for Selenium server (INFO) as it is too
 #    # verbose.
@@ -1744,7 +1744,7 @@ steps:
 
 services:
 - name: selenium
-  image: selenium/standalone-firefox:2.53.1-beryllium
+  image: selenium/standalone-chrome:3.141.59
   environment:
     # Reduce default log level for Selenium server (INFO) as it is too
     # verbose.
@@ -1774,7 +1774,7 @@ steps:
 
 services:
 - name: selenium
-  image: selenium/standalone-firefox:2.53.1-beryllium
+  image: selenium/standalone-chrome:3.141.59
   environment:
     # Reduce default log level for Selenium server (INFO) as it is too
     # verbose.
@@ -1804,7 +1804,7 @@ steps:
 
 services:
 - name: selenium
-  image: selenium/standalone-firefox:2.53.1-beryllium
+  image: selenium/standalone-chrome:3.141.59
   environment:
     # Reduce default log level for Selenium server (INFO) as it is too
     # verbose.
@@ -1834,7 +1834,7 @@ steps:
 
 services:
 - name: selenium
-  image: selenium/standalone-firefox:2.53.1-beryllium
+  image: selenium/standalone-chrome:3.141.59
   environment:
     # Reduce default log level for Selenium server (INFO) as it is too
     # verbose.
@@ -1864,7 +1864,7 @@ steps:
 
 services:
 - name: selenium
-  image: selenium/standalone-firefox:2.53.1-beryllium
+  image: selenium/standalone-chrome:3.141.59
   environment:
     # Reduce default log level for Selenium server (INFO) as it is too
     # verbose.
@@ -1894,7 +1894,7 @@ steps:
 
 services:
 - name: selenium
-  image: selenium/standalone-firefox:2.53.1-beryllium
+  image: selenium/standalone-chrome:3.141.59
   environment:
     # Reduce default log level for Selenium server (INFO) as it is too
     # verbose.
@@ -1924,7 +1924,7 @@ steps:
 
 services:
 - name: selenium
-  image: selenium/standalone-firefox:2.53.1-beryllium
+  image: selenium/standalone-chrome:3.141.59
   environment:
     # Reduce default log level for Selenium server (INFO) as it is too
     # verbose.
@@ -1954,7 +1954,7 @@ steps:
 
 services:
 - name: selenium
-  image: selenium/standalone-firefox:2.53.1-beryllium
+  image: selenium/standalone-chrome:3.141.59
   environment:
     # Reduce default log level for Selenium server (INFO) as it is too
     # verbose.
@@ -1984,7 +1984,7 @@ steps:
 
 services:
 - name: selenium
-  image: selenium/standalone-firefox:2.53.1-beryllium
+  image: selenium/standalone-chrome:3.141.59
   environment:
     # Reduce default log level for Selenium server (INFO) as it is too
     # verbose.

tests/acceptance/config/behat.yml

@@ -65,15 +65,35 @@ default:
         default:
           selenium2:
             wd_host: %selenium.server%
+            browser: "chrome"
+            capabilities:
+              extra_capabilities:
+                goog:chromeOptions:
+                  w3c: false
         John:
           selenium2:
             wd_host: %selenium.server%
+            browser: "chrome"
+            capabilities:
+              extra_capabilities:
+                goog:chromeOptions:
+                  w3c: false
         Jane:
           selenium2:
             wd_host: %selenium.server%
+            browser: "chrome"
+            capabilities:
+              extra_capabilities:
+                goog:chromeOptions:
+                  w3c: false
         Jim:
           selenium2:
             wd_host: %selenium.server%
+            browser: "chrome"
+            capabilities:
+              extra_capabilities:
+                goog:chromeOptions:
+                  w3c: false
         Rubeus:
           # Rubeus uses a browser that has CSS grid support.
           selenium2:

tests/acceptance/run.sh

@@ -108,12 +108,12 @@ function prepareSelenium() {
 	SELENIUM_CONTAINER=selenium-nextcloud-local-test-acceptance
 
 	echo "Starting Selenium server"
-	docker run --detach --name=$SELENIUM_CONTAINER --publish 4444:4444 --publish 5900:5900 $DOCKER_OPTIONS selenium/standalone-firefox-debug:2.53.1-beryllium
+	docker run --detach --name=$SELENIUM_CONTAINER --publish 4444:4444 --publish 5900:5900 --shm-size 256m $DOCKER_OPTIONS selenium/standalone-chrome-debug:3.141.59
 
 	echo "Waiting for Selenium server to be ready"
 	if ! $TIMEOUT 10s bash -c "while ! curl 127.0.0.1:4444 >/dev/null 2>&1; do sleep 1; done"; then
 		echo "Could not start Selenium server; running" \
-		     "\"docker run --rm --publish 4444:4444 --publish 5900:5900 $DOCKER_OPTIONS selenium/standalone-firefox-debug:2.53.1-beryllium\"" \
+		     "\"docker run --rm --publish 4444:4444 --publish 5900:5900 $DOCKER_OPTIONS selenium/standalone-chrome-debug:3.141.59\"" \
 		     "could give you a hint of the problem"
 
 		exit 1