Skip to content

Commit 9ff3b29

Browse files
authored
Merge pull request #32247 from nextcloud/backport/31032/stable23
[stable23] Don't use plain URL on the email subject
2 parents adc0690 + c565f4a commit 9ff3b29

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

apps/settings/lib/Hooks.php

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828

2929
use OCA\Settings\Activity\Provider;
3030
use OCP\Activity\IManager as IActivityManager;
31+
use OCP\Defaults;
3132
use OCP\IConfig;
3233
use OCP\IGroupManager;
3334
use OCP\IURLGenerator;
@@ -55,6 +56,8 @@ class Hooks {
5556
protected $config;
5657
/** @var IFactory */
5758
protected $languageFactory;
59+
/** @var Defaults */
60+
protected $defaults;
5861

5962
public function __construct(IActivityManager $activityManager,
6063
IGroupManager $groupManager,
@@ -63,7 +66,8 @@ public function __construct(IActivityManager $activityManager,
6366
IURLGenerator $urlGenerator,
6467
IMailer $mailer,
6568
IConfig $config,
66-
IFactory $languageFactory) {
69+
IFactory $languageFactory,
70+
Defaults $defaults) {
6771
$this->activityManager = $activityManager;
6872
$this->groupManager = $groupManager;
6973
$this->userManager = $userManager;
@@ -72,6 +76,7 @@ public function __construct(IActivityManager $activityManager,
7276
$this->mailer = $mailer;
7377
$this->config = $config;
7478
$this->languageFactory = $languageFactory;
79+
$this->defaults = $defaults;
7580
}
7681

7782
/**
@@ -93,6 +98,7 @@ public function onChangePassword($uid) {
9398
->setType('personal_settings')
9499
->setAffectedUser($user->getUID());
95100

101+
$instanceName = $this->defaults->getName();
96102
$instanceUrl = $this->urlGenerator->getAbsoluteURL('/');
97103
$language = $this->languageFactory->getUserLanguage($user);
98104
$l = $this->languageFactory->get('settings', $language);
@@ -131,7 +137,7 @@ public function onChangePassword($uid) {
131137
'instanceUrl' => $instanceUrl,
132138
]);
133139

134-
$template->setSubject($l->t('Password for %1$s changed on %2$s', [$user->getDisplayName(), $instanceUrl]));
140+
$template->setSubject($l->t('Password for %1$s changed on %2$s', [$user->getDisplayName(), $instanceName]));
135141
$template->addHeader();
136142
$template->addHeading($l->t('Password changed for %s', [$user->getDisplayName()]), false);
137143
$template->addBodyText($text . ' ' . $l->t('If you did not request this, please contact an administrator.'));

0 commit comments

Comments
 (0)