fix: skip caching lastSeenQuotaUsage for remote shares

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Author: kesselb

apps/dav/tests/unit/Connector/Sabre/DirectoryTest.php

@@ -283,8 +283,9 @@ public function testGetQuotaInfoUnlimited(): void {
 		$storage->expects($this->any())
 			->method('instanceOfStorage')
 			->willReturnMap([
-				'\OCA\Files_Sharing\SharedStorage' => false,
-				'\OC\Files\Storage\Wrapper\Quota' => false,
+				['\OCA\Files_Sharing\SharedStorage', false],
+				['\OC\Files\Storage\Wrapper\Quota', false],
+				[\OCA\Files_Sharing\External\Storage::class, false],
 			]);
 
 		$storage->expects($this->once())
@@ -314,6 +315,10 @@ public function testGetQuotaInfoUnlimited(): void {
 			->method('getRelativePath')
 			->willReturn('/foo');
 
+		$this->info->expects($this->once())
+			->method('getInternalPath')
+			->willReturn('/foo');
+
 		$mountPoint->method('getMountPoint')
 			->willReturn('/user/files/mymountpoint');
 
@@ -336,6 +341,7 @@ public function testGetQuotaInfoSpecific(): void {
 			->willReturnMap([
 				['\OCA\Files_Sharing\SharedStorage', false],
 				['\OC\Files\Storage\Wrapper\Quota', true],
+				[\OCA\Files_Sharing\External\Storage::class, false],
 			]);
 
 		$storage->expects($this->once())
@@ -358,6 +364,10 @@ public function testGetQuotaInfoSpecific(): void {
 			->method('getMountPoint')
 			->willReturn($mountPoint);
 
+		$this->info->expects($this->once())
+			->method('getInternalPath')
+			->willReturn('/foo');
+
 		$mountPoint->method('getMountPoint')
 			->willReturn('/user/files/mymountpoint');
 

lib/private/legacy/OC_Helper.php

@@ -541,10 +541,17 @@ public static function getStorageInfo($path, $rootInfo = null, $includeMountPoin
 			$relative = 0;
 		}
 
-		/** @var string $ownerId */
+		/*
+		 * \OCA\Files_Sharing\External\Storage returns the cloud ID as the owner for the storage.
+		 * It is unnecessary to query the user manager for the display name, as it won't have this information.
+		 */
+		$isRemoteShare = $storage->instanceOfStorage(\OCA\Files_Sharing\External\Storage::class);
+
 		$ownerId = $storage->getOwner($path);
+		$hasOwnerId = $ownerId !== false && $ownerId !== null;
 		$ownerDisplayName = '';
-		if ($ownerId) {
+
+		if ($isRemoteShare === false && $hasOwnerId) {
 			$ownerDisplayName = \OC::$server->getUserManager()->getDisplayName($ownerId) ?? '';
 		}
 
@@ -566,7 +573,7 @@ public static function getStorageInfo($path, $rootInfo = null, $includeMountPoin
 			'mountPoint' => trim($mountPoint, '/'),
 		];
 
-		if ($ownerId && $path === '/') {
+		if ($isRemoteShare === false && $hasOwnerId && $path === '/') {
 			// If path is root, store this as last known quota usage for this user
 			\OCP\Server::get(\OCP\IConfig::class)->setUserValue($ownerId, 'files', 'lastSeenQuotaUsage', (string)$relative);
 		}