Skip to content

Commit be9e1fd

Browse files
committed
Fix icons for bundled perms in sharing details
It appears `NcCheckboxRadioSwitch` does not take icons via `<template #icon>` (at least not anymore) but two options in the bundled perms still used that and that has been fixed in this commit. Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
1 parent 34373d4 commit be9e1fd

File tree

9 files changed

+16
-21
lines changed

9 files changed

+16
-21
lines changed

apps/files_sharing/src/views/SharingDetailsTab.vue

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -34,15 +34,12 @@
3434
type="radio"
3535
button-variant-grouped="vertical"
3636
@update:checked="toggleCustomPermissions">
37+
<EditIcon :size="20" />
3738
<template v-if="allowsFileDrop">
38-
{{ t('files_sharing', 'Allow upload and editing') }}
39+
<span>{{ t('files_sharing', 'Allow upload and editing') }}</span>
3940
</template>
4041
<template v-else>
41-
{{ t('files_sharing', 'Allow editing') }}
42-
</template>
43-
44-
<template #icon>
45-
<EditIcon :size="20" />
42+
<span>{{ t('files_sharing', 'Allow editing') }}</span>
4643
</template>
4744
</NcCheckboxRadioSwitch>
4845
<NcCheckboxRadioSwitch v-if="allowsFileDrop"
@@ -64,11 +61,9 @@
6461
type="radio"
6562
button-variant-grouped="vertical"
6663
@update:checked="expandCustomPermissions">
67-
{{ t('files_sharing', 'Custom permissions') }}
64+
<DotsHorizontalIcon :size="20" />
65+
<span>{{ t('files_sharing', 'Custom permissions') }}</span>
6866
<small>{{ customPermissionsList }}</small>
69-
<template #icon>
70-
<DotsHorizontalIcon :size="20" />
71-
</template>
7267
</NcCheckboxRadioSwitch>
7368
</div>
7469
</div>

core/css/server.css

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

core/css/server.css.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/core-common.js

Lines changed: 2 additions & 2 deletions
Large diffs are not rendered by default.

dist/core-common.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/files-main.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/files-main.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/files_sharing-files_sharing_tab.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/files_sharing-files_sharing_tab.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)