Skip to content

Commit d86975e

Browse files
Merge pull request #56923 from nextcloud/fix/update-all
fix(settings): update all button only updates a single app
2 parents 8eb2415 + f6a783e commit d86975e

File tree

6 files changed

+11
-10
lines changed

6 files changed

+11
-10
lines changed

apps/settings/src/components/AppList.vue

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -351,13 +351,14 @@ export default {
351351
})
352352
},
353353
354-
updateAll() {
354+
async updateAll() {
355355
const limit = pLimit(1)
356-
this.apps
356+
const updateTasks = this.apps
357357
.filter((app) => app.update)
358358
.map((app) => limit(() => {
359359
this.update(app.id)
360360
}))
361+
await Promise.all(updateTasks)
361362
},
362363
},
363364
}

apps/settings/src/mixins/AppManagement.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -255,11 +255,11 @@ export default {
255255
},
256256
update(appId) {
257257
if (this.app?.app_api) {
258-
this.appApiStore.updateApp(appId)
258+
return this.appApiStore.updateApp(appId)
259259
.then(() => { rebuildNavigation() })
260260
.catch((error) => { showError(error) })
261261
} else {
262-
this.$store.dispatch('updateApp', { appId })
262+
return this.$store.dispatch('updateApp', { appId })
263263
.catch((error) => { showError(error) })
264264
.then(() => {
265265
rebuildNavigation()

dist/settings-apps-view-4529.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/settings-apps-view-4529.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/settings-vue-settings-apps-users-management.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/settings-vue-settings-apps-users-management.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)