Skip to content

Commit ecf33a6

Browse files
authored
Merge pull request #11417 from nextcloud/hover-quota-used-space-regression
Add back the total used space per user
2 parents 9eb4259 + 8a2ac44 commit ecf33a6

File tree

6 files changed

+42
-17
lines changed

6 files changed

+42
-17
lines changed

settings/js/settings-vue.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

settings/js/settings-vue.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

settings/package-lock.json

Lines changed: 31 additions & 12 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

settings/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "settings",
33
"description": "Nextcloud settings",
4-
"version": "1.3.0",
4+
"version": "1.3.1",
55
"author": "John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>",
66
"license": "AGPL3",
77
"private": true,

settings/src/components/userList/userRow.vue

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@
8484
<span slot="noResult">{{t('settings', 'No results')}}</span>
8585
</multiselect>
8686
</div>
87-
<div class="quota" :class="{'icon-loading-small': loading.quota}">
87+
<div class="quota" :class="{'icon-loading-small': loading.quota}" v-tooltip.auto="usedSpace">
8888
<multiselect :value="userQuota" :options="quotaOptions" :disabled="loading.quota||loading.all"
8989
tag-placeholder="create" :placeholder="t('settings', 'Select user quota')"
9090
label="label" track-by="id" class="multiselect-vue"
@@ -215,6 +215,12 @@ export default {
215215
},
216216
217217
/* QUOTA MANAGEMENT */
218+
usedSpace() {
219+
if (this.user.quota.used) {
220+
return t('settings', '{size} used', {size: OC.Util.humanFileSize(this.user.quota.used)});
221+
}
222+
return t('settings', '{size} used', {size: OC.Util.humanFileSize(0)});
223+
},
218224
usedQuota() {
219225
let quota = this.user.quota.quota;
220226
if (quota > 0) {

tests/acceptance/features/bootstrap/UsersSettingsContext.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ public static function rowForUser($user) {
9090
* @return Locator
9191
*/
9292
public static function classCellForUser($class, $user) {
93-
return Locator::forThe()->xpath("//*[@class='$class']")->
93+
return Locator::forThe()->xpath("//*[contains(concat(' ', normalize-space(@class), ' '), ' $class ')]")->
9494
descendantOf(self::rowForUser($user))->
9595
describedAs("$class cell for user $user in Users Settings");
9696
}

0 commit comments

Comments
 (0)