Modify do_action so default ctrl-click opens tab

Modify do_action to use an ID number
Use item in do_action instead of currentFile
Limit launching direct actions to one time
Use full file item instead of attr-only

Signed-off-by: phillip <phillipsmyth@codethink.co.uk>

Author: phillip

apps/files/js/filelist.js

@@ -432,7 +432,7 @@
 					this.setupUploadEvents(this._uploader);
 				}
 			}
-
+			this.triedActionOnce = false;
 
 			OC.Plugins.attach('OCA.Files.FileList', this);
 
@@ -874,7 +874,7 @@
 			if ($tr.hasClass('dragging')) {
 				return;
 			}
-			if (this._allowSelection && (event.ctrlKey || event.shiftKey)) {
+			if (this._allowSelection && (event.shiftKey)) {
 				event.preventDefault();
 				if (event.shiftKey) {
 					this._selectRange($tr);
@@ -883,6 +883,7 @@
 				}
 				this._lastChecked = $tr;
 				this.updateSelectionSummary();
+			} else if (this._allowSelection && (event.ctrlKey)) {
 			} else {
 				// clicked directly on the name
 				if (!this._detailsView || $(event.target).is('.nametext, .name, .thumbnail') || $(event.target).closest('.nametext').length) {
@@ -892,18 +893,10 @@
 						event.preventDefault();
 					} else if (!renaming) {
 						this.fileActions.currentFile = $tr.find('td');
-						var mime = this.fileActions.getCurrentMimeType();
-						var type = this.fileActions.getCurrentType();
-						var permissions = this.fileActions.getCurrentPermissions();
-						var action = this.fileActions.getDefault(mime,type, permissions);
-						if (action) {
+						var item = this.$fileList.children().filterAttr('data-id', '' + $tr.attr('data-id'));
+
+						if(this.openAction($tr.attr('data-id'))) {
 							event.preventDefault();
-							action(filename, {
-								$file: $tr,
-								fileList: this,
-								fileActions: this.fileActions,
-								dir: $tr.attr('data-path') || this.getCurrentDirectory()
-							});
 						}
 						// deselect row
 						$(event.target).closest('a').blur();
@@ -933,6 +926,28 @@
 			}
 		},
 
+		openAction: function(id) {
+			var item = this.$fileList.children().filterAttr('data-id', '' + id);
+			var filename = item.attr('data-file');
+			// also set on global object for legacy apps
+			window.FileActions.currentFile = item.find('td');
+			this.fileActions.currentFile = item.find('td');
+			var mime = this.fileActions.getCurrentMimeType();
+			var type = this.fileActions.getCurrentType();
+			var permissions = this.fileActions.getCurrentPermissions();
+			var action = this.fileActions.getDefault(mime,type, permissions);
+			if (action) {
+				action(filename, {
+					$file: item,
+					fileList: this,
+					fileActions: this.fileActions,
+					dir: item.attr('data-path') || this.getCurrentDirectory()
+				});
+				return true;
+		    }
+		    return false;
+		},
+
 		/**
 		 * Event handler for when clicking on a file's checkbox
 		 */
@@ -1322,7 +1337,11 @@
 					}
 				}, 0);
 			}
-
+			if(!this.triedActionOnce) {
+				var urlParams = OC.Util.History.parseUrlQuery();
+				this.openAction(urlParams.editfile);
+				this.triedActionOnce = true;
+			}
 			return newTrs;
 		},
 
@@ -1532,7 +1551,7 @@
 				linkUrl = this.linkTo(path + '/' + name);
 			}
 			else {
-				linkUrl = this.getDownloadUrl(name, path, type === 'dir');
+				linkUrl = this.linkTo(path) + "&editfile="+fileData.id;
 			}
 			var linkElem = $('<a></a>').attr({
 				"class": "name",