adjust Calendar resource / room interfaces to use class implementation#10839
adjust Calendar resource / room interfaces to use class implementation#10839MorrisJobke merged 2 commits intomasterfrom
Conversation
| continue; | ||
| } | ||
|
|
||
| $this->initializedBackends[$backend] = \OC::$server->query($backend); |
There was a problem hiding this comment.
Should we try to catch the QueryException in case it is thrown?
There was a problem hiding this comment.
FYI: if you inject the IServerContainer via the constructor you can actually unit test this 😉
| * @since 14.0.0 | ||
| */ | ||
| public function getBackend($backendId):IBackend; | ||
| public function getBackend($backendId); |
There was a problem hiding this comment.
Or we keep it and throw an \OutOfBoundsException
There was a problem hiding this comment.
@georgehrke throw instead of having to check types everytime?
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Found a nitpick (see comment above), other than that it looks good as far as I can tell 👍
MorrisJobke
added
2. developing
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
… OC Server Signed-off-by: Georg Ehrke <developer@georgehrke.com>
georgehrke
force-pushed
the
bugfix/10212/use_class_implementation
branch
from
640db6d to
970242b
Compare
|
rebased and injecting |
georgehrke
added
3. to review
| * Registers a resource backend | ||
| * | ||
| * @param IBackend $backend | ||
| * @param string $backendClass |
There was a problem hiding this comment.
OCP breaking change 🙈 @rullzer @nickvergessen @blizzz Opinions?
There was a problem hiding this comment.
dont care since its new and not used yet by anyone
|
@georgehrke Mind to open the backport PR? |
🏓 |
|
/backport to stable14 |
|
backport to stable14 in #12617 |
5 participants
fixes #10212