Skip to content

Run oci tests against phpunit9/php8 #24827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kesselb merged 3 commits into from
Sep 28, 2021
Merged

Run oci tests against phpunit9/php8 #24827

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cab44b6
Run oci tests against phpunit9/php8
juliusknorr Dec 23, 2020
1e266e8
Run oci against all php versions
juliusknorr Jan 5, 2021
9161f6c
Remove tests that just prove mocked calls and don't actually validate…
juliusknorr Apr 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Run oci tests against phpunit9/php8 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
  • Loading branch information
@juliusknorr @MichaIng
juliusknorr authored and MichaIng committed Sep 27, 2021
commit cab44b6311d9ea51ac33e1382e65ddd0bedd95e1
6 changes: 3 additions & 3 deletions .github/workflows/oci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
# do not stop on another job's failure
fail-fast: false
matrix:
php-versions: [ '7.4' ]
php-versions: [ '8.0' ]
databases: [ 'oci' ]

name: php${{ matrix.php-versions }}-${{ matrix.databases }}
Expand All @@ -41,8 +41,8 @@ jobs:
uses: shivammathur/setup-php@v2
with:
php-version: ${{ matrix.php-versions }}
extensions: ctype,curl,dom,fileinfo,gd,iconv,intl,json,mbstring,oci8,openssl,pdo_sqlite,posix,sqlite,xml,zip
tools: phpunit:8.5.2
extensions: ctype,curl,dom,fileinfo,gd,iconv,imagick,intl,json,mbstring,oci8,openssl,pdo_sqlite,posix,sqlite,xml,zip
tools: phpunit:9
coverage: none

- name: Set up Nextcloud
Expand Down
1 change: 1 addition & 0 deletions tests/lib/TestCase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
use OCP\IDBConnection;
use OCP\IL10N;
use OCP\Security\ISecureRandom;
use PHPUnit\Util\Test;
Copy link
Member

@blizzz blizzz Apr 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused

Copy link
Member

@blizzz blizzz Sep 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this statement is still superfluous, isn't it?

Copy link
Member

@MichaIng MichaIng Sep 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI will tell us. I'll remove it now.


abstract class TestCase extends \PHPUnit\Framework\TestCase {
/** @var \OC\Command\QueueBus */
Expand Down