[stable26] Ungroup placeholder css rules to prevent browsers from removing all rules#37793
Merged
[stable26] Ungroup placeholder css rules to prevent browsers from removing all rules#37793
placeholder css rules to prevent browsers from removing all rules#37793Conversation
Contributor
|
/compile amend / |
nextcloud-command
force-pushed
the
backport/37522/stable26
branch
from
95829c7 to
3babe15
Compare
szaimen
approved these changes
Apr 18, 2023
susnux
approved these changes
Apr 18, 2023
Pytal
approved these changes
Apr 18, 2023
Pytal
added
4. to release
Contributor
|
Drone error is unrelated. |
Merged
Member
|
conflicts |
…emoving all rules When rules are grouped using the comma operator and one selector is invalid / unknown then the whole group is invalidated[1]. In this case `::-ms-input-placeholder` is unknown to Firefox and Chrome, so the `::placeholder` rule is never applied. [1]: https://www.w3.org/TR/selectors-3/#grouping Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
susnux
force-pushed
the
backport/37522/stable26
branch
from
3babe15 to
25cde39
Compare
Contributor
@blizzz resolved |
Member
|
→ 26.0.3 |
Merged
Member
|
Merged after RC1, will revert |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #37522