Skip to content

[stable31] fix(db): Create replacement index where original index is missing #52394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndyScherzinger merged 1 commit into from
Apr 24, 2025
Merged

[stable31] fix(db): Create replacement index where original index is missing #52394

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(db): Create replacement index where original index is missing 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
  • Loading branch information
@ChristophWurst @backportbot
ChristophWurst authored and backportbot[bot] committed Apr 23, 2025
commit 2dfda1ea26a5a6423040459759ff3a66f3efc401
15 changes: 5 additions & 10 deletions core/Command/Db/AddMissingIndices.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,14 +86,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
if ($schema->hasTable($toReplaceIndex['tableName'])) {
$table = $schema->getTable($toReplaceIndex['tableName']);

$allOldIndicesExists = true;
foreach ($toReplaceIndex['oldIndexNames'] as $oldIndexName) {
if (!$table->hasIndex($oldIndexName)) {
$allOldIndicesExists = false;
}
}

if (!$allOldIndicesExists) {
if ($table->hasIndex($toReplaceIndex['newIndexName'])) {
continue;
}

Expand All @@ -110,8 +103,10 @@ protected function execute(InputInterface $input, OutputInterface $output): int
}

foreach ($toReplaceIndex['oldIndexNames'] as $oldIndexName) {
$output->writeln('<info>Removing ' . $oldIndexName . ' index from the ' . $table->getName() . ' table</info>');
$table->dropIndex($oldIndexName);
if ($table->hasIndex($oldIndexName)) {
$output->writeln('<info>Removing ' . $oldIndexName . ' index from the ' . $table->getName() . ' table</info>');
$table->dropIndex($oldIndexName);
}
}

if (!$dryRun) {
Expand Down
Loading