Skip to content

Migrate angular 17 - #517

Merged
mdasberg merged 12 commits into
ng-apimock:masterfrom
stefanoslig:migrate-angular-17
Nov 30, 2023
Merged

Migrate angular 17#517
mdasberg merged 12 commits into
ng-apimock:masterfrom
stefanoslig:migrate-angular-17

Conversation

@stefanoslig

@stefanoslig stefanoslig commented Nov 18, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Angular 17
  • Standalone component
  • Lazy loaded routes
    image
  • Tiny rebranding
    image

@stefanoslig
stefanoslig marked this pull request as draft November 18, 2023 20:16
@mdasberg

mdasberg commented Nov 19, 2023

Copy link
Copy Markdown
Contributor

Hi @stefanoslig thanks for starting this pr. Do you need any help?

@stefanoslig

stefanoslig commented Nov 20, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Hey @mdasberg . Thanks for reaching out!

What I need is a PR review when you have time. Also, I'm not sure if you agree with the tiny rebranding of the app I did in order to be closer to the new brand of Angular.

I still need to check that everything works as expected( unit, e2e tests, etc). I'll try to do this during this week

@stefanoslig
stefanoslig marked this pull request as ready for review November 20, 2023 20:35
@stefanoslig

stefanoslig commented Nov 29, 2023

Copy link
Copy Markdown
Contributor Author

Hi @mdasberg ! I noticed that the unit tests are failing also in the master branch. I think it's better fix them in a separate branch. Could you please check my changes and merge the PR if you agree with them?

@mdasberg

mdasberg commented Nov 29, 2023

Copy link
Copy Markdown
Contributor

@stefanoslig I fixed the unit tests on your branch.
Working on the integration tests atm

@stefanoslig

stefanoslig commented Nov 30, 2023

Copy link
Copy Markdown
Contributor Author

That's great! If you need help with this, let me know

@mdasberg
mdasberg merged commit 2288d2f into ng-apimock:master Nov 30, 2023
mdasberg added a commit that referenced this pull request Nov 30, 2023
@mdasberg
feature: migrate angular 17 (#517)
3f687f7
mdasberg added a commit that referenced this pull request Nov 30, 2023
@mdasberg
feat: migrate angular 17 (#517)
00b07c7
github-actions Bot pushed a commit that referenced this pull request Nov 30, 2023
@semantic-release-bot
chore(release): 3.3.0 [skip ci]
a45366a 
# [3.3.0](v3.2.1...v3.3.0) (2023-11-30)

### Features

* migrate angular 17 ([#517](#517)) ([00b07c7](00b07c7))
@mdasberg

mdasberg commented Nov 30, 2023

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 3.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@stefanoslig

stefanoslig commented Nov 30, 2023

Copy link
Copy Markdown
Contributor Author

Thanks a lot for all the work you did in the PR @mdasberg!! 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stefanoslig @mdasberg