fix(store): prevent unexpected behavior of {} as a props type (#2728)

Author: markostanimirovic

modules/store/spec/types/action_creator.spec.ts

@@ -43,13 +43,21 @@ describe('createAction()', () => {
       );
     });
 
-    it('should not allow ararys', () => {
+    it('should not allow arrays', () => {
       expectSnippet(`
         const foo = createAction('FOO', props<[]>());
       `).toFail(
         /Type 'Props<\[\]>' is not assignable to type '"arrays are not allowed in action creators"'/
       );
     });
+
+    it('should not allow empty objects', () => {
+      expectSnippet(`
+        const foo = createAction('FOO', props<{}>());
+      `).toFail(
+        /Type 'Props<\{\}>' is not assignable to type '"empty objects are not allowed in action creators"'/
+      );
+    });
   });
 
   describe('with function', () => {

modules/store/src/models.ts

@@ -61,6 +61,10 @@ export const typePropertyIsNotAllowedMsg =
   'type property is not allowed in action creators';
 type TypePropertyIsNotAllowed = typeof typePropertyIsNotAllowedMsg;
 
+export const emptyObjectsAreNotAllowedMsg =
+  'empty objects are not allowed in action creators';
+type EmptyObjectsAreNotAllowed = typeof emptyObjectsAreNotAllowedMsg;
+
 export type FunctionIsNotAllowed<
   T,
   ErrorMessage extends string
@@ -77,6 +81,8 @@ export type NotAllowedCheck<T extends object> = T extends any[]
   ? ArraysAreNotAllowed
   : T extends { type: any }
   ? TypePropertyIsNotAllowed
+  : keyof T extends never
+  ? EmptyObjectsAreNotAllowed
   : unknown;
 
 /**