feat(schematics): add createEffect migration#2136
Conversation
|
Preview docs changes for 991e44b at https://previews.ngrx.io/pr2136-991e44b/ |
|
Preview docs changes for 4b20b2c at https://previews.ngrx.io/pr2136-4b20b2c/ |
|
I don't see a test for @Effect()
effectAsMethod() {
return this.actions$...;
}Did you check that this gets migrated, too? Or will these intentionally not get migrated? |
|
Thanks @dummdidumm ! |
|
Also maybe as a part of this PR information about this migration should be added to the documentation? |
|
⚠ Do not merge now ⚠ There's an issue with this migration, the |
|
Preview docs changes for 9e630ee at https://previews.ngrx.io/pr2136-9e630ee/ |
|
Removing the |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #
What is the new behavior?
This PR adds a new schematic
create-effect-migrationto migrate from the@Effect()decorator to thecreateEffect()function.Does this PR introduce a breaking change?
Other information