fix(Effects): Start child effects after running root effects#43
Merged
brandonroberts merged 1 commit intomasterfrom Jun 20, 2017
Merged
fix(Effects): Start child effects after running root effects#43brandonroberts merged 1 commit intomasterfrom
brandonroberts merged 1 commit intomasterfrom
Conversation
MikeRyanDev
force-pushed
the
fix/run-effects-on-initialization
branch
from
4414e62 to
e89140f
Compare
Member
|
LGTM |
This removes the app initialization logic altogether. The 'OnRunEffects' lifecycle hook should be sufficient to control when your effects start.
MikeRyanDev
force-pushed
the
fix/run-effects-on-initialization
branch
from
e89140f to
7a7861b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the app initialization logic altogether. The 'OnRunEffects'
lifecycle hook should be sufficient to control when your effects start.
cc @robwormald
Closes #37