fix(RouterStore): support objects for options of StoreRouterConnectingModule#575
Merged
brandonroberts merged 1 commit intongrx:masterfrom Nov 18, 2017
Merged
Conversation
brandonroberts
requested changes
Nov 17, 2017
| @@ -125,10 +125,12 @@ export const ROUTER_CONFIG = new InjectionToken( | |||
| export const DEFAULT_ROUTER_FEATURENAME = 'routerReducer'; | |||
|
|
|||
| export function _createDefaultRouterConfig(config: any): StoreRouterConfig { | |||
Member
There was a problem hiding this comment.
Change config argument type to StoreRouterConfig | StoreRouterConfigFunction
|
|
||
| export function _createDefaultRouterConfig(config: any): StoreRouterConfig { | ||
| let _config = {}; | ||
| let _config: any; |
Member
There was a problem hiding this comment.
Change _config to StoreRouterConfig
Member
|
Thanks @fredgate for the PR! I left you some feedback. |
fredgate
force-pushed
the
fix-routerstore-config
branch
from
8495fc7 to
70043e1
Compare
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue #573