Merge pull request acts-project#104 from asalzburger/chore-remove-sheets

feat!: removing sheets

Author: asalzburger

README.md

@@ -13,7 +13,7 @@ This module has the core definition and plotting functionality for primitives.
 
 This module acts as a translation layer between the caller libraries (etc. `ACTS`, `detray`) and core library.
 It allows to create `proto` objects for detectors that can then be used for plotting using the `core` module.
-This module does also contain a dedicated `display` area that prepares some standard sheets, a view examples can be placed below.
+This module does also contain a dedicated `display` area that assists in displaying the objects.
 
 # Python bindings
 
@@ -36,14 +36,6 @@ A view stand-alone files that are produced by the `googletest` based unit testin
 </tr>
 </table>
 
-An example for an endcap sheet:
-
-<img src="https://github.com/acts-project/actsvg/blob/main/docs/svg/odd_endcap_sheet_module_info.svg" width=600/>
-
-An example for a barrel sheet (module info display):
-
-<img src="https://github.com/acts-project/actsvg/blob/main/docs/svg/odd_barrel_sheet_module_info.svg" width=600/>
-
 ## Getting started
 
 To build `actsvg` using CMake execute the following

core/include/actsvg/core/connectors.hpp

@@ -29,7 +29,7 @@ enum type { e_highlight, e_associate_id, e_associate_info };
  * @param sources_ are the source objects
  * @param targests_ are the target objects
  * @param s_t_connections_ are the connections from source to target
- * @param ls_ label the source or not (in case of multiple connection sheets)
+ * @param ls_ label the source or not (in case of multiple connections)
  * @param on_off_ are the connection effects
  *
  * In case of e.g. a grid surface connection:

docs/svg/odd_barrel_sheet_module_info.svg

@@ -7,7 +7,6 @@ actsvg_add_library( actsvg_meta meta
    "include/actsvg/display/grids.hpp"
    "include/actsvg/display/helpers.hpp"
    "include/actsvg/display/materials.hpp"
-   "include/actsvg/display/sheets.hpp"
    "include/actsvg/proto/cluster.hpp"
    "include/actsvg/proto/detector.hpp"
    "include/actsvg/proto/grid.hpp"

docs/svg/odd_endcap_sheet_module_info.svg

@@ -133,7 +133,7 @@ views::contour range_contour(const surface_type& s_,
         contour = view.path(vertices_disc);
     } else {
         throw std::invalid_argument(
-            "surface_sheet_xy(...) - could not estimate range.");
+            "range_contour(...) - could not estimate range.");
     }
     return contour;
 }
@@ -166,7 +166,7 @@ static std::array<std::array<scalar, 2>, 2> view_range(
  *
  * @param v_ volume of the detector
  * @param view_ the view used for this
- * @param sh_ the sheet size
+ * @param sh_ the canvas size
  * @param es_ is the equal scale
  * @param hl_ switch highlighting on/off
  * @param dt_ draw template is available
@@ -249,55 +249,6 @@ process_modules(const volume_type& v_, const view_type& view_,
     return {all_modules, scale_transform, axes};
 }
 
-/** Helper method to connect the surface sheets to the
- * surfaces of the layer_sheets
- *
- * @tparam volume_type the type of volume (templated on point3_container)
- *
- * @param v_ the input volume
- * @param templates_ the given module templtes
- * @param o_ the object to which they are attached
- *
- **/
-template <typename volume_type>
-void connect_surface_sheets(const volume_type& v_,
-                            std::vector<std::vector<svg::object>>& templates_,
-                            svg::object& o_) {
-    // Now create an item per surface
-    for (auto [ib, surface_batch] : utils::enumerate(v_._surfaces)) {
-        for (auto [is, s] : utils::enumerate(surface_batch)) {
-            std::string sid = s._name;
-
-            svg::object& s_sheet_s = templates_[ib][is];
-            s_sheet_s._attribute_map["display"] = "none";
-
-            // Object information to appear
-            svg::object on;
-            on._tag = "animate";
-            on._attribute_map["fill"] = "freeze";
-            on._attribute_map["attributeName"] = "display";
-            on._attribute_map["from"] = "none";
-            on._attribute_map["to"] = "block";
-            on._attribute_map["begin"] = sid + __d + "mouseout";
-
-            svg::object off;
-
-            off._tag = "animate";
-            off._attribute_map["fill"] = "freeze";
-            off._attribute_map["attributeName"] = "display";
-            off._attribute_map["to"] = "none";
-            off._attribute_map["from"] = "block";
-            off._attribute_map["begin"] = sid + __d + "mouseover";
-
-            // Store the animation
-            s_sheet_s._sub_objects.push_back(off);
-            s_sheet_s._sub_objects.push_back(on);
-
-            o_.add_object(s_sheet_s);
-        }
-    }
-}
-
 }  // namespace display
 
 }  // namespace actsvg