Move version check screen to TitleState#155
Merged
ninjamuffin99 merged 1 commit intoFunkinCrew:masterfrom Jan 15, 2021
gedehari:version-check-fix
Merged
Move version check screen to TitleState#155ninjamuffin99 merged 1 commit intoFunkinCrew:masterfrom gedehari:version-check-fix
ninjamuffin99 merged 1 commit intoFunkinCrew:masterfrom
gedehari:version-check-fix
Conversation
Member
|
aw yeahhh aight shawty |
kudorado
pushed a commit
to kudorado/Funkin
that referenced
this pull request
Jul 18, 2021
Move version check screen to TitleState
ninjamuffin99
added a commit
that referenced
this pull request
Mar 9, 2023
Move version check screen to TitleState
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving the version check screen to TitleState, allows the game to make early decisions whether to switch to MainMenuState or OutdatedSubState.
Also solves the weird trantition bug.
Before:
version-check-fix--before.mp4
After:
version-check-fix--after.mp4
Let me know if there needs to be a change before merging. Thanks.