Removed old fetcher code and tests

Author: nkl-kst

.github/workflows/ci.yml

@@ -39,4 +39,3 @@ jobs:
 
             # Tests
             - run: npm test
-            - run: npm run test-functional

MMM-OnThisDay.js

@@ -43,7 +43,7 @@ const moduleDefinition = {
     /**
      * Separate events parsed from the HTML data.
      */
-    events: null,
+    events: [],
 
     /**
      * Event years for carousel model.
@@ -73,7 +73,6 @@ const moduleDefinition = {
     getScripts: function () {
         // prettier-ignore
         return [
-            this.file('src/WikiCssSelectors.js'),
             this.file('src/ProgressUpdater.js'),
         ];
     },
@@ -131,11 +130,8 @@ const moduleDefinition = {
     start: function () {
         Log.info('MMM-OnThisDay starting...');
 
-        // Check languages
-        const configuredLanguage = this.config.language || config.language;
-        if (WIKI_CSS_SELECTORS[configuredLanguage]) {
-            this.usedLanguage = configuredLanguage;
-        }
+        // Determine languages
+        this.usedLanguage = this.config.language || config.language;
         Log.info(`Using language ${this.usedLanguage}.`);
     },
 

package.json

@@ -16,8 +16,7 @@
     "scripts": {
         "cs-check": "prettier --check .",
         "cs-fix": "prettier --write .",
-        "test": "nyc mocha test/unit --recursive",
-        "test-functional": "mocha test/functional --recursive"
+        "test": "nyc mocha test/unit --recursive"
     },
     "devDependencies": {
         "mocha": "^10.2.0",
@@ -33,8 +32,7 @@
         ],
         "exclude": [
             "coverage",
-            "test",
-            "src/WikiCssSelectors.js"
+            "test"
         ],
         "cache": true,
         "all": true

src/HtmlFetcher.js

@@ -15,14 +15,13 @@ const NodeHelperFake = {
     },
 };
 
-const htmlFetcherMock = {
+const wikimediaApiFetcherMock = {
     fetch: (language) => {
-        return `
-            <div id="mp-otd">
-                <p>test title for ${language}</p>
-                <ul><li>test events for ${language}</li></ul>
-            </div>
-		`;
+        return [
+            {
+                text: `test events for ${language}`,
+            },
+        ];
     },
 };
 
@@ -38,7 +37,7 @@ const nodeHelperDefinition = proxyquire('../../node_helper', {
 module.exports = function () {
     const nodeHelper = Object.assign({}, nodeHelperDefinition);
 
-    nodeHelper.start(htmlFetcherMock, null, loggerMock);
+    nodeHelper.start(wikimediaApiFetcherMock, loggerMock);
 
     // Fake inherited methods
     nodeHelper.sendSocketNotification = sinon.fake();

src/HtmlParser.js

@@ -24,9 +24,6 @@ Log = {
 // Load module definition
 const moduleDefinition = require('../../MMM-OnThisDay');
 
-// Load Wiki CSS selectors
-WIKI_CSS_SELECTORS = require('../../src/WikiCssSelectors');
-
 // Export new module with function mocks/fakes
 module.exports = function () {
     // Create module