Skip to content

Commit 1055c45

Browse files
authored
Merge pull request #43 from noahlz/release/signing
Add code signing for macOS releases. Windows signing still todo.
2 parents 0c2c2d9 + 94c056c commit 1055c45

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

.github/workflows/_build-artifacts.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,10 @@ jobs:
3535
- run: npm run rebuild:electron
3636
- run: npx electron-builder --mac --universal --publish never
3737
env:
38-
CSC_IDENTITY_AUTO_DISCOVERY: false
38+
CSC_LINK: ${{ secrets.CSC_LINK }}
39+
CSC_KEY_PASSWORD: ${{ secrets.CSC_KEY_PASSWORD }}
40+
APPLE_ID: ${{ secrets.APPLE_ID }}
41+
APPLE_APP_SPECIFIC_PASSWORD: ${{ secrets.APPLE_APP_SPECIFIC_PASSWORD }}
3942
- name: Get version
4043
id: version
4144
run: echo "version=$(node -p "require('./package.json').version")" >> $GITHUB_OUTPUT
@@ -49,6 +52,7 @@ jobs:
4952
retention-days: 1
5053

5154
build-win:
55+
# TODO: Code Signing
5256
name: Build (Windows)
5357
needs: test
5458
runs-on: windows-latest

electron-builder.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,10 @@
2020
"mac": {
2121
"target": ["dmg"],
2222
"category": "public.app-category.games",
23-
"icon": "resources/icons/mac/icon.icns"
23+
"icon": "resources/icons/mac/icon.icns",
24+
"notarize": {
25+
"teamId": "2R45ZG5BZL"
26+
}
2427
},
2528
"win": {
2629
"target": ["nsis"],

0 commit comments

Comments
 (0)