Skip to content

Commit 52147de

Browse files
hoythandead-horse
authored andcommitted
fix: query parameters are not allowed to be included in where (ali-sdk#67)
1 parent cbb8503 commit 52147de

File tree

2 files changed

+11
-4
lines changed

2 files changed

+11
-4
lines changed

lib/operator.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -159,9 +159,6 @@ proto.update = function* (table, row, options) {
159159
const values = [];
160160
for (let i = 0; i < options.columns.length; i++) {
161161
const column = options.columns[i];
162-
if (column in options.where) {
163-
continue;
164-
}
165162
sets.push('?? = ?');
166163
values.push(column);
167164
values.push(row[column]);

test/async.js

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -747,10 +747,20 @@ describe('async.test.js', function() {
747747
});
748748
assert.equal(result.affectedRows, 1);
749749

750+
result = await this.db.update(table, {
751+
email: prefix + 'm@fengmk2-update3.com',
752+
}, {
753+
where: {
754+
name: prefix + 'fengmk2-update',
755+
email: prefix + 'm@fengmk2-update2.com',
756+
},
757+
});
758+
assert.equal(result.affectedRows, 1);
759+
750760
user = await this.db.get(table, {
751761
name: prefix + 'fengmk2-update',
752762
});
753-
assert.deepEqual(user.email, prefix + 'm@fengmk2-update2.com');
763+
assert.deepEqual(user.email, prefix + 'm@fengmk2-update3.com');
754764
assert.deepEqual(new Date(user.gmt_create), new Date('2000'));
755765
assert(user.gmt_modified instanceof Date);
756766

0 commit comments

Comments
 (0)