labels: add version labels#55
labels: add version labels#55mscdex wants to merge 1 commit intonodejs:masterfrom mscdex:add-version-labels
Conversation
|
I wasn't sure exactly how to test the webhook, but going by the github webhook docs that should be the correct property for obtaining the base branch from the webhook event data. |
Np, no one else has gotten around creating automated tests for webhooks so far - hopefully some day :) The easiest way to test webhooks locally ATM would be via SSE relay functionality. @williamkapke could you add the necessary relay webhook to https://github.com/TestOrgPleaseIgnore/node? |
|
Perhaps just mock the api response from the version we're talking to? |
|
Yeah, I've got a branch ready to push soon which mocks every call made to GH |
|
Awesome! |
| : matchAllSubSystem(filepathsChanged, limitLib) | ||
|
|
||
| // Add version labels if PR is made against a version branch | ||
| const m = /^(v\d+\.(?:\d+|x))(?:-|$)/.exec(baseBranch) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
This is now live in production |
|
Comment was ignored? :/ |
@Fishrock123 sry, didn't see your comment! I'll get a PR up right away... Was this a coincident you having a look at this old & stalled PR, and me working to get it merged?? |
Minor adjustment to the regex matching the base branch a PR is targeted against. Refs nodejs#55 (comment)
|
Hooray, it works!: nodejs/node#8437 |
|
Yiiiiiha, nice work! @mscdex you got any objections to this On Thursday, 8 September 2016, Brian White notifications@github.com wrote:
|
Minor adjustment to the regex matching the base branch a PR is targeted against. Refs #55 (comment)
4 participants
No description provided.