Skip to content

test: more consistent test for findjsobjects -d #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joyeecheung merged 1 commit into from
May 2, 2018
Merged

test: more consistent test for findjsobjects -d #188

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions test/scan-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ function test(executable, core, t) {

sess.linesUntil(versionMark, (err, lines) => {
t.error(err);
t.ok(/\d+ Zlib/.test(lines.join('\n')), 'Zlib should be in findjsobjects');
t.ok(/\d+ Class/.test(lines.join('\n')), 'Class should be in findjsobjects');

sess.send('v8 findjsobjects -d');
// Just a separator
Expand All @@ -46,9 +46,8 @@ function test(executable, core, t) {

sess.linesUntil(versionMark, (err, lines) => {
t.error(err);
t.ok(/0 +0 Zlib/.test(lines.join('\n')), 'Zlib should be in findjsobjects -d');
t.ok(/1 +0 Zlib: onerror/.test(lines.join('\n')),
'"Zlib: onerror" should be in findjsobjects -d');
t.ok(/3 +0 Class: x, y, hashmap/.test(lines.join('\n')),
'"Class: x, y, hashmap" should be in findjsobjects -d');

sess.send('v8 findjsinstances Zlib');
// Just a separator
Expand Down