Run linter (clang-format) on Travis#260
Closed
mmarchini wants to merge 3 commits intonodejs:masterfrom
Closed
Conversation
richardlau
approved these changes
Jan 18, 2019
mmarchini
added
the
author ready
joyeecheung
reviewed
Jan 29, 2019
Member
|
Ping @mmarchini This needs a rebase |
Codecov Report
@@ Coverage Diff @@
## master #260 +/- ##
=======================================
Coverage 79.96% 79.96%
=======================================
Files 34 34
Lines 4292 4292
=======================================
Hits 3432 3432
Misses 860 860
Continue to review full report at Codecov.
|
joyeecheung
approved these changes
Feb 26, 2019
Contributor
Author
|
Done. I also moved |
mmarchini
added a commit
that referenced
this pull request
Feb 26, 2019
PR-URL: #260 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
mmarchini
added a commit
that referenced
this pull request
Feb 26, 2019
PR-URL: #260 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
mmarchini
added a commit
that referenced
this pull request
Feb 26, 2019
PR-URL: #260 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Contributor
Author
|
Landed in ea06ef5...85f067a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.