review: only look for LGTMs in <p>'s

TimothyGu · TimothyGu · commit ca1c6714dcf1 · 2017-02-01T09:53:52.000-08:00
Fixes: nodejs/node#10657
diff --git a/review.js b/review.js
@@ -351,8 +351,8 @@
       const href = a.getAttribute('href')
       if (!href) continue
       const login = href.slice(1).toLowerCase()
-      const body = comment.querySelector('.comment-body')
-      if (body && LGTM_RE.test(body.innerHTML)) {
+      const paragraphs = comment.querySelectorAll('.comment-body > p')
+      if (Array.from(paragraphs).some(p => LGTM_RE.test(p.innerHTML))) {
         revs.push(login)
       }
     }

Original file line number	Diff line number	Diff line change
`@@ -351,8 +351,8 @@`
`351`	`351`	`const href = a.getAttribute('href')`
`352`	`352`	`if (!href) continue`
`353`	`353`	`const login = href.slice(1).toLowerCase()`
`354`		`- const body = comment.querySelector('.comment-body')`
`355`		`- if (body && LGTM_RE.test(body.innerHTML)) {`
	`354`	`+ const paragraphs = comment.querySelectorAll('.comment-body > p')`
	`355`	`+ if (Array.from(paragraphs).some(p => LGTM_RE.test(p.innerHTML))) {`
`356`	`356`	`revs.push(login)`
`357`	`357`	`}`
`358`	`358`	`}`